Structures::getTotalDescendants()

brandonkelly · brandonkelly · commit 86e196cb339f · 2024-05-15T15:26:16.000-07:00
Avoids 100 element count queries per structure index page
diff --git a/src/services/Structures.php b/src/services/Structures.php
@@ -296,6 +296,26 @@ public function getElementLevelDelta(int $structureId, ElementInterface $element
         return 0;
     }
 
+    /**
+     * Returns the total number of descendants for a given structure element.
+     *
+     * @param ElementInterface $element
+     * @return int
+     * @since 5.2.0
+     */
+    public function getTotalDescendants(ElementInterface $element): int
+    {
+        if (!$element->structureId || $element->lft === null || !$element->rgt === null) {
+            return 0;
+        }
+
+        return StructureElement::find()
+            ->where(['structureId' => $element->structureId])
+            ->andWhere(['>', 'structureelements.lft', $element->lft])
+            ->andWhere(['<', 'structureelements.rgt', $element->rgt])
+            ->count();
+    }
+
     // Moving elements around
     // -------------------------------------------------------------------------
 
diff --git a/src/templates/_elements/tableview/elements.twig b/src/templates/_elements/tableview/elements.twig
@@ -1,19 +1,13 @@
 {% apply spaceless %}
 
 {% set structure = structure is defined ? structure : null -%}
+{% set structuresService = structure ? craft.app.structures : null %}
 {% set structureEditable = structureEditable is defined and not inlineEditing ? structureEditable : false -%}
 {% set padding = craft.app.locale.getOrientation() == 'ltr' ? 'left' : 'right' -%}
 {% set elementsService = craft.app.elements %}
 
 {% for element in elements %}
-    {% set totalDescendants = structure
-        ? element.getDescendants()
-            .status(null)
-            .drafts(null)
-            .draftOf(false)
-            .savedDraftsOnly()
-            .count()
-        : 0 %}
+    {% set totalDescendants = structure ? structuresService.getTotalDescendants(element) : 0 %}
     {% set elementTitle = element.title ?: element.id %}
     {% set showInputs = (inlineEditing ?? false) and elementsService.canSave(element, currentUser) %}
     <tr data-id="{{ element.id }}"{% if structure %} data-title="{{ elementTitle }}" data-level="{{ element.level }}" data-descendants="{{ totalDescendants ?? 0 }}"{% endif %}{% if element.id in disabledElementIds %} class="disabled"{% endif %}>
