Invalidate user caches on activation/unlock/suspension/etc

brandonkelly · brandonkelly · commit 52154d71dc45 · 2021-10-11T19:15:00.000-07:00
Fixes #9947
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 ### Fixed
 - Fixed a bug where entry drafts weren’t getting propagated to other sites automatically after a section’s Propagation Method setting was changed. ([#9944](https://github.com/craftcms/cms/issues/9944))
+- Fixed a bug where user indexes weren’t immediately showing changes to users’ activation/suspension states. ([#9947](https://github.com/craftcms/cms/issues/9947))
 
 ## 3.7.16 - 2021-10-06
 
diff --git a/src/services/Users.php b/src/services/Users.php
@@ -669,6 +669,9 @@ public function activateUser(User $user): bool
             ]));
         }
 
+        // Invalidate caches
+        Craft::$app->getElements()->invalidateCachesForElement($user);
+
         return true;
     }
 
@@ -753,6 +756,9 @@ public function unlockUser(User $user): bool
             ]));
         }
 
+        // Invalidate caches
+        Craft::$app->getElements()->invalidateCachesForElement($user);
+
         return true;
     }
 
@@ -795,6 +801,9 @@ public function suspendUser(User $user): bool
             ]));
         }
 
+        // Invalidate caches
+        Craft::$app->getElements()->invalidateCachesForElement($user);
+
         return true;
     }
 
@@ -841,6 +850,9 @@ public function unsuspendUser(User $user): bool
             ]));
         }
 
+        // Invalidate caches
+        Craft::$app->getElements()->invalidateCachesForElement($user);
+
         return true;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -669,6 +669,9 @@ public function activateUser(User $user): bool`
`669`	`669`	`]));`
`670`	`670`	`}`
`671`	`671`
	`672`	`+ // Invalidate caches`
	`673`	`+ Craft::$app->getElements()->invalidateCachesForElement($user);`
	`674`	`+`
`672`	`675`	`return true;`
`673`	`676`	`}`
`674`	`677`
`@@ -753,6 +756,9 @@ public function unlockUser(User $user): bool`
`753`	`756`	`]));`
`754`	`757`	`}`
`755`	`758`
	`759`	`+ // Invalidate caches`
	`760`	`+ Craft::$app->getElements()->invalidateCachesForElement($user);`
	`761`	`+`
`756`	`762`	`return true;`
`757`	`763`	`}`
`758`	`764`
`@@ -795,6 +801,9 @@ public function suspendUser(User $user): bool`
`795`	`801`	`]));`
`796`	`802`	`}`
`797`	`803`
	`804`	`+ // Invalidate caches`
	`805`	`+ Craft::$app->getElements()->invalidateCachesForElement($user);`
	`806`	`+`
`798`	`807`	`return true;`
`799`	`808`	`}`
`800`	`809`
`@@ -841,6 +850,9 @@ public function unsuspendUser(User $user): bool`
`841`	`850`	`]));`
`842`	`851`	`}`
`843`	`852`
	`853`	`+ // Invalidate caches`
	`854`	`+ Craft::$app->getElements()->invalidateCachesForElement($user);`
	`855`	`+`
`844`	`856`	`return true;`
`845`	`857`	`}`
`846`	`858`