Repository navigation
fix(ui): hide SDK heartbeats from repeated tool rows - #1075
Open
lakers-abing wants to merge 1 commit into
Open
lakers-abing wants to merge 1 commit into
lakers-abing wants to merge 1 commit into
Conversation
lakers-abing
force-pushed
the
codex/fix-tool-heartbeat-ui
branch
from
October 20, 2026 15:01
2aa1ff4 to
ba82283
Compare
Author
|
Could a maintainer please approve the external-contributor Validate workflow for this PR? Its upstream workflow has not executed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1008.
Testing
Rebased onto upstream
mainat89e2d6a25fb1c5c46e27ecf8e8f9a744f5abc27bon 2026-10-20. Final PR head:ba822836bbadcf80ebf124c09d2d10ca7fb94ab1. The diff remains the original three-file fix (+97/-5); no dependency manifests, lockfile, or workflows are changed by this PR.Local validation with CI-pinned Bun 1.3.10:
bun test packages/ui/src/components/chat/__tests__/: 82 passed, 0 failed, including the heartbeat regressions.bun run typecheck:all: passed across all workspaces included by that script;workers/pagesis absent in the OSS export and the script skips it explicitly.git diff --check: passed.bun run test: the initial whole-repository Bun pass completed with 6,391 passed, 12 skipped, 118 failed, 8 errors. The same pass on the exact latest-main parent (89e2d6a) with the same installed third-party dependencies gave 6,389 passed, 12 skipped, 118 failed, 8 errors. Comparing failed file/test pairs found no failures unique to this PR; the two new regressions account for the passing-test delta. The later isolated-test loop was not reached because the first phase failed.The whole suite is not claimed green. Failures include sandbox-blocked socket listeners and default config/docs paths, plus existing agent/context cases. Dependency setup is also incomplete:
bun install --frozen-lockfile --ignore-scriptsstalled on registry downloads with both the local proxy and direct connections, including a lower-concurrency retry. These checks used cached and partially updated dependencies; they do not establish a clean frozen install or native dependency setup. All tracked dependency inputs are unchanged.The new upstream Validate run is still
action_requiredpending an upstream maintainer's approval: https://github.com/craft-ai-agents/craft-agents-oss/actions/runs/39444645444 . Local results are separate from completed upstream CI.Screenshots
Not captured; a local Electron build was unavailable.