Skip to content

fix(ui): hide SDK heartbeats from repeated tool rows - #1075

Open
lakers-abing wants to merge 1 commit into
craft-ai-agents:mainfrom
lakers-abing:codex/fix-tool-heartbeat-ui
Open

lakers-abing wants to merge 1 commit into
craft-ai-agents:mainfrom
lakers-abing:codex/fix-tool-heartbeat-ui

Conversation

@lakers-abing

@lakers-abing lakers-abing commented Sep 26, 2026 •

Copy link
Copy Markdown

Summary

  • Show a long-running tool call as one chat activity while SDK heartbeat progress records arrive.
  • Keep orphaned heartbeat records and genuine child tool calls visible.
  • Add regression coverage and a pending release note.

Fixes #1008.

Testing

Rebased onto upstream main at 89e2d6a25fb1c5c46e27ecf8e8f9a744f5abc27b on 2026-10-20. Final PR head: ba822836bbadcf80ebf124c09d2d10ca7fb94ab1. The diff remains the original three-file fix (+97/-5); no dependency manifests, lockfile, or workflows are changed by this PR.

Local validation with CI-pinned Bun 1.3.10:

  • bun test packages/ui/src/components/chat/__tests__/: 82 passed, 0 failed, including the heartbeat regressions.
  • bun run typecheck:all: passed across all workspaces included by that script; workers/pages is absent in the OSS export and the script skips it explicitly.
  • git diff --check: passed.
  • bun run test: the initial whole-repository Bun pass completed with 6,391 passed, 12 skipped, 118 failed, 8 errors. The same pass on the exact latest-main parent (89e2d6a) with the same installed third-party dependencies gave 6,389 passed, 12 skipped, 118 failed, 8 errors. Comparing failed file/test pairs found no failures unique to this PR; the two new regressions account for the passing-test delta. The later isolated-test loop was not reached because the first phase failed.

The whole suite is not claimed green. Failures include sandbox-blocked socket listeners and default config/docs paths, plus existing agent/context cases. Dependency setup is also incomplete: bun install --frozen-lockfile --ignore-scripts stalled on registry downloads with both the local proxy and direct connections, including a lower-concurrency retry. These checks used cached and partially updated dependencies; they do not establish a clean frozen install or native dependency setup. All tracked dependency inputs are unchanged.

The new upstream Validate run is still action_required pending an upstream maintainer's approval: https://github.com/craft-ai-agents/craft-agents-oss/actions/runs/39444645444 . Local results are separate from completed upstream CI.

Screenshots

Not captured; a local Electron build was unavailable.

@lakers-abing
lakers-abing force-pushed the codex/fix-tool-heartbeat-ui branch from 2aa1ff4 to ba82283 Compare October 20, 2026 15:01
@lakers-abing

Copy link
Copy Markdown
Author

Could a maintainer please approve the external-contributor Validate workflow for this PR? Its upstream workflow has not executed (action_required). The PR description records the actual local Bun regression, complete typecheck, and whole-suite baseline comparison, including the existing failures and validation limits. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long-running tool calls render heartbeat progress entries as repeated tool invocations in the UI

1 participant