Repository navigation
Make written MIDI tempo rounding opt-in - #266
Merged
Merged
Conversation
Owner
|
Thanks, but this needs some kind of argument that allows for backwards-compatible behavior. |
Owner
|
ThankS! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #103 with opt-in rounding while preserving existing writes.
PrettyMIDI.write(filename, round_tempo=True)usesmido.bpm2tempo()to round MIDI tempos to the nearest integer microsecond per quarter note. For example, 123 BPM becomes 487805 instead of 487804. Omitting the argument, or passinground_tempo=False, retains the previous truncation behavior.The method documents the option. Regression tests decode written MIDI bytes and cover the default and explicit modes, integer tempo changes across four resolutions and three read/write cycles when rounding is enabled, boundary tempo values, unchanged note ticks, and unchanged in-memory timing data.
Validation on Linux with Python 3.12, NumPy 2.5.4 and mido 1.3.3:
python -m pytest tests -q: 29 passed, with the existingadjust_timeswarning.python -m flake8 tests/test_write_tempo.pyandgit diff --check: passed.The legacy
nosetests -v --with-coverage --cover-package=pretty_midicommand cannot start on Python 3.12 because nose imports the removedimpmodule. Python 2.7/3.5 and DAW playback were not tested.