-
Notifications
You must be signed in to change notification settings - Fork 71
Comparing changes
Open a pull request
base repository: cpuguy83/go-md2man
base: v2.0.6
head repository: cpuguy83/go-md2man
compare: v2.0.7
- 17 commits
- 7 files changed
- 5 contributors
Commits on Feb 17, 2025
-
Bump golangci/golangci-lint-action from 6.1.1 to 6.5.0
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.1 to 6.5.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.1.1...v6.5.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e455f03 - Browse repository at this point
Copy the full SHA e455f03View commit details -
Merge pull request #135 from cpuguy83/dependabot/github_actions/golan…
…gci/golangci-lint-action-6.5.0 Bump golangci/golangci-lint-action from 6.1.1 to 6.5.0
Configuration menu - View commit details
-
Copy full SHA for ae8f92a - Browse repository at this point
Copy the full SHA ae8f92aView commit details
Commits on Mar 17, 2025
-
Bump golangci/golangci-lint-action from 6.5.0 to 6.5.2
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.5.0 to 6.5.2. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.5.0...v6.5.2) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9657ca0 - Browse repository at this point
Copy the full SHA 9657ca0View commit details
Commits on Mar 18, 2025
-
Update installation instructions to v2 module path
Fix the installation instructions to use v2 module as same as the module path in go.mod file.
Configuration menu - View commit details
-
Copy full SHA for 1432a71 - Browse repository at this point
Copy the full SHA 1432a71View commit details -
Add usage instructions with
go toolfor go 1.24+Add usage instructions for using go-md2man with the `go tool`. refer to https://go.dev/doc/go1.24#go-command https://go.dev/ref/mod#go-mod-file-tool
Configuration menu - View commit details
-
Copy full SHA for f875ad2 - Browse repository at this point
Copy the full SHA f875ad2View commit details
Commits on Mar 21, 2025
-
Merge pull request #138 from cpuguy83/dependabot/github_actions/golan…
…gci/golangci-lint-action-6.5.2 Bump golangci/golangci-lint-action from 6.5.0 to 6.5.2
Configuration menu - View commit details
-
Copy full SHA for c346003 - Browse repository at this point
Copy the full SHA c346003View commit details -
Merge pull request #139 from huiyifyj/v2-and-go-tool
Update usage instructions and fix module path
Configuration menu - View commit details
-
Copy full SHA for 80d4cc2 - Browse repository at this point
Copy the full SHA 80d4cc2View commit details
Commits on Apr 24, 2025
-
This fixes the following staticcheck warnings: > md2man/debug.go:1:1: ST1000: at least one file in a package should have a package comment (staticcheck) > package md2man > ^ > md2man/md2man.go:3:1: ST1000: at least one file in a package should have a package comment (staticcheck) > package md2man > ^ Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2d0f4c5 - Browse repository at this point
Copy the full SHA 2d0f4c5View commit details -
md2man: rm unused nolint directive
This fixes the following golangci-lint v2 warning: > WARN [runner/nolint_filter] Found unknown linters in //nolint directives: golint Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d95447a - Browse repository at this point
Copy the full SHA d95447aView commit details -
gha: switch to ubuntu-24.04, modern Go versions
Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 50e20fb - Browse repository at this point
Copy the full SHA 50e20fbView commit details -
Configuration was initially converted by golangci-lint migrate, when heavily edited to minimize/optimize. We are excluing staticcheck QF1008 as it is too opinionated: > md2man/roff.go:136:24: QF1008: could remove embedded field "LinkData" from selector (staticcheck) > if !bytes.Equal(node.LinkData.Destination, node.FirstChild.Literal) { > ^ > md2man/roff.go:140:49: QF1008: could remove embedded field "LinkData" from selector (staticcheck) > escapedLink := strings.ReplaceAll(string(node.LinkData.Destination), "-", "\\-") > ^ Signed-off-by: Kir Kolyshkin <[email protected]>Configuration menu - View commit details
-
Copy full SHA for fc51eb3 - Browse repository at this point
Copy the full SHA fc51eb3View commit details -
There should be no space between // and nolint. A space after nolint: is optional, but remove it as well. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dfd185f - Browse repository at this point
Copy the full SHA dfd185fView commit details -
md2man: remove unused parameters
This fixes the following unparam warning: > md2man/roff_test.go:448:45: execRecoverableTestSuite - tests is unused (unparam) > func execRecoverableTestSuite(t *testing.T, tests []string, params TestParams, suite func(candidate *string)) { > ^ Signed-off-by: Kir Kolyshkin <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 68539cc - Browse repository at this point
Copy the full SHA 68539ccView commit details -
.golangci.yml: add some more linters
Those are not enabled by default but can be useful. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 993ceeb - Browse repository at this point
Copy the full SHA 993ceebView commit details -
Merge pull request #142 from kolyshkin/golangci-v2
Make CI green again, bump golangci-lint to v2
Configuration menu - View commit details
-
Copy full SHA for 75548be - Browse repository at this point
Copy the full SHA 75548beView commit details -
Currently, when a long cell in the table is not the last (rightmost), due to extra \n the rendering is broken, resulting in an extra row. The fix is easy -- do not add \n after T} unless it's the last cell. Add a test case, which (before the fix) is rendered like this: ... │ robin │ red. │ ├────────────────────────┼────────────────────────┤ │ Meerschweinchen a.k.a. │ │ │ guinea pig │ │ ├────────────────────────┼────────────────────────┤ │ │ Varies. │ └────────────────────────┴────────────────────────┘ With the fix, it is rendered correctly now: ... │ robin │ red. │ ├────────────────────────┼────────────────────────┤ │ Meerschweinchen a.k.a. │ Varies. │ │ guinea pig │ │ └────────────────────────┴────────────────────────┘ Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dcb0114 - Browse repository at this point
Copy the full SHA dcb0114View commit details -
Merge pull request #141 from kolyshkin/fix-long-tables
Table rendering fix
Configuration menu - View commit details
-
Copy full SHA for 061b6c7 - Browse repository at this point
Copy the full SHA 061b6c7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.6...v2.0.7