Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cpuguy83/go-md2man
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.6
Choose a base ref
...
head repository: cpuguy83/go-md2man
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.7
Choose a head ref
  • 17 commits
  • 7 files changed
  • 5 contributors

Commits on Feb 17, 2025

  1. Bump golangci/golangci-lint-action from 6.1.1 to 6.5.0

    Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.1 to 6.5.0.
    - [Release notes](https://github.com/golangci/golangci-lint-action/releases)
    - [Commits](golangci/golangci-lint-action@v6.1.1...v6.5.0)
    
    ---
    updated-dependencies:
    - dependency-name: golangci/golangci-lint-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    e455f03 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #135 from cpuguy83/dependabot/github_actions/golan…

    …gci/golangci-lint-action-6.5.0
    
    Bump golangci/golangci-lint-action from 6.1.1 to 6.5.0
    thaJeztah authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    ae8f92a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. Bump golangci/golangci-lint-action from 6.5.0 to 6.5.2

    Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.5.0 to 6.5.2.
    - [Release notes](https://github.com/golangci/golangci-lint-action/releases)
    - [Commits](golangci/golangci-lint-action@v6.5.0...v6.5.2)
    
    ---
    updated-dependencies:
    - dependency-name: golangci/golangci-lint-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Mar 17, 2025
    Configuration menu
    Copy the full SHA
    9657ca0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2025

  1. Update installation instructions to v2 module path

    Fix the installation instructions to use v2 module as same as the module path in go.mod file.
    huiyifyj committed Mar 18, 2025
    Configuration menu
    Copy the full SHA
    1432a71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f875ad2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2025

  1. Merge pull request #138 from cpuguy83/dependabot/github_actions/golan…

    …gci/golangci-lint-action-6.5.2
    
    Bump golangci/golangci-lint-action from 6.5.0 to 6.5.2
    cpuguy83 authored Mar 21, 2025
    Configuration menu
    Copy the full SHA
    c346003 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #139 from huiyifyj/v2-and-go-tool

    Update usage instructions and fix module path
    cpuguy83 authored Mar 21, 2025
    Configuration menu
    Copy the full SHA
    80d4cc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2025

  1. md2man: add package overview

    This fixes the following staticcheck warnings:
    
    > md2man/debug.go:1:1: ST1000: at least one file in a package should have a package comment (staticcheck)
    > package md2man
    > ^
    > md2man/md2man.go:3:1: ST1000: at least one file in a package should have a package comment (staticcheck)
    > package md2man
    > ^
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    2d0f4c5 View commit details
    Browse the repository at this point in the history
  2. md2man: rm unused nolint directive

    This fixes the following golangci-lint v2 warning:
    
    > WARN [runner/nolint_filter] Found unknown linters in //nolint directives: golint
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    d95447a View commit details
    Browse the repository at this point in the history
  3. gha: switch to ubuntu-24.04, modern Go versions

    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    50e20fb View commit details
    Browse the repository at this point in the history
  4. golangci-lint: use v2

    Configuration was initially converted by golangci-lint migrate, when
    heavily edited to minimize/optimize.
    
    We are excluing staticcheck QF1008 as it is too opinionated:
    
    > md2man/roff.go:136:24: QF1008: could remove embedded field "LinkData" from selector (staticcheck)
    > 		if !bytes.Equal(node.LinkData.Destination, node.FirstChild.Literal) {
    > 		                     ^
    > md2man/roff.go:140:49: QF1008: could remove embedded field "LinkData" from selector (staticcheck)
    > 		escapedLink := strings.ReplaceAll(string(node.LinkData.Destination), "-", "\\-")
    > 		                                              ^
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    fc51eb3 View commit details
    Browse the repository at this point in the history
  5. Fix nolint directives

    There should be no space between // and nolint.
    
    A space after nolint: is optional, but remove it as well.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    dfd185f View commit details
    Browse the repository at this point in the history
  6. md2man: remove unused parameters

    This fixes the following unparam warning:
    
    > md2man/roff_test.go:448:45: execRecoverableTestSuite - tests is unused (unparam)
    > func execRecoverableTestSuite(t *testing.T, tests []string, params TestParams, suite func(candidate *string)) {
    >                                             ^
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    68539cc View commit details
    Browse the repository at this point in the history
  7. .golangci.yml: add some more linters

    Those are not enabled by default but can be useful.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    993ceeb View commit details
    Browse the repository at this point in the history
  8. Merge pull request #142 from kolyshkin/golangci-v2

    Make CI green again, bump golangci-lint to v2
    cpuguy83 authored Apr 24, 2025
    Configuration menu
    Copy the full SHA
    75548be View commit details
    Browse the repository at this point in the history
  9. Table rendering fix

    Currently, when a long cell in the table is not the last (rightmost),
    due to extra \n the rendering is broken, resulting in an extra row.
    
    The fix is easy -- do not add \n after T} unless it's the last cell.
    
    Add a test case, which (before the fix) is rendered like this:
    
    	...
    
    	│ robin                  │ red.                   │
    	├────────────────────────┼────────────────────────┤
    	│ Meerschweinchen a.k.a. │                        │
    	│ guinea pig             │                        │
    	├────────────────────────┼────────────────────────┤
    	│                        │ Varies.                │
    	└────────────────────────┴────────────────────────┘
    
    With the fix, it is rendered correctly now:
    
    	...
    
    	│ robin                  │ red.                   │
    	├────────────────────────┼────────────────────────┤
    	│ Meerschweinchen a.k.a. │ Varies.                │
    	│ guinea pig             │                        │
    	└────────────────────────┴────────────────────────┘
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    dcb0114 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #141 from kolyshkin/fix-long-tables

    Table rendering fix
    cpuguy83 authored Apr 24, 2025
    Configuration menu
    Copy the full SHA
    061b6c7 View commit details
    Browse the repository at this point in the history
Loading