Skip to content

Conversation

@2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Feb 11, 2024

PR review should only show summary comment and exclude suggestions in diff.

github-actions[bot]

This comment was marked as outdated.

@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@cpp-linter cpp-linter deleted a comment from github-actions bot Feb 11, 2024
@github-actions
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted
  • src/demo.cpp
  • src/demo.hpp
clang-tidy reports: 4 concern(s)

Have any feedback or feature suggestions? Share it here.

@github-actions github-actions bot dismissed their stale review February 11, 2024 22:51

outdated suggestion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..c522998 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..8f92cac 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -8 +8,5 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
@@ -11 +15 @@ class Dummy {
-    void *not_useful(char *str){useless = str;}
+        void* not_useful(char* str) { useless = str; }
@@ -14,17 +17,0 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
@@ -34,2 +21 @@ struct LongDiff
-    long diff;
-
+        long diff;
Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +17,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..2591c48 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -11 +11 @@ class Dummy {
-    void *not_useful(char *str){useless = str;}
+        auto not_useful(char* str) -> void* { useless = str; }

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants