Skip to content

Update for transfer ownership #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shenxianpeng merged 1 commit into from
May 7, 2022
Merged

Update for transfer ownership #60

shenxianpeng merged 1 commit into from
May 7, 2022
+18 −18

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Apr 28, 2022

No description provided.

@shenxianpeng shenxianpeng requested a review from 2bndy5 April 28, 2022 05:31
@shenxianpeng shenxianpeng added the documentation Improvements or additions to documentation label Apr 28, 2022
@2bndy5
Copy link
Collaborator

2bndy5 commented Apr 28, 2022

Personally, I'd prefer to wait to do this until after the transfer. That way we can confirm the existing workflows out there aren't broken by the transfer.

  1. Close this PR, but keep the branch.
  2. Transfer the repo
  3. Re-open a PR to merge this branch into master

@shenxianpeng
Copy link
Collaborator Author

shenxianpeng commented Apr 28, 2022

Sure, no problem

@shenxianpeng
Copy link
Collaborator Author

shenxianpeng commented May 7, 2022

I'm back from vacation... @2bndy5 Do you think it's time to consider merging this PR?

@2bndy5
Copy link
Collaborator

2bndy5 commented May 7, 2022

Yep. No problems reported, so I'm ok to move forward on this.

@shenxianpeng
Copy link
Collaborator Author

shenxianpeng commented May 7, 2022

Cool!

@shenxianpeng shenxianpeng reopened this May 7, 2022
@shenxianpeng shenxianpeng merged commit d886080 into master May 7, 2022
@shenxianpeng shenxianpeng deleted the transfer-update branch May 7, 2022 08:06
@shenxianpeng shenxianpeng mentioned this pull request May 9, 2022
Closed
@shenxianpeng shenxianpeng mentioned this pull request Mar 7, 2024
Merged
shenxianpeng added a commit that referenced this pull request Mar 7, 2024
@shenxianpeng
change action.yml and doc files #203 (#204)
494ce6d 
* update description, add clang-tools v18 to action.yml
* add clang-tools v18 to inputs-outputs.md
* follow up #60, change author from `shenxianpeng` to `cpp-linter` in action.yml after transfer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenxianpeng @2bndy5