Skip to content

Update thread-comments condition in self-test.yml - #326

Merged
shenxianpeng merged 2 commits into
mainfrom
shenxianpeng-patch-1
Sep 3, 2025
Merged

Update thread-comments condition in self-test.yml#326
shenxianpeng merged 2 commits into
mainfrom
shenxianpeng-patch-1

Conversation

@shenxianpeng

Copy link
Copy Markdown
Member

Right now merge PR will be added thread-comments, see b20a30f

I would like to disable it for merged commits.

Right now merge PR will be added thread-comments, see b20a30f

I would like to disable it for merged commits.
@shenxianpeng shenxianpeng added the developer Changes which impact developers label Sep 2, 2025
@shenxianpeng
shenxianpeng requested a review from a team as a code owner September 2, 2025 19:48
@shenxianpeng
shenxianpeng requested review from 2bndy5 and removed request for a team September 2, 2025 19:48
@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.hpp
  • docs/examples/demo/demo.cpp
clang-tidy (v16.0.6) reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

@2bndy5 2bndy5 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also update it to only post comments (and file-annotations) using clang v16

@shenxianpeng
shenxianpeng merged commit e94da0a into main Sep 3, 2025
84 checks passed
@shenxianpeng
shenxianpeng deleted the shenxianpeng-patch-1 branch September 3, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Changes which impact developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants