thread-comments are not exclusive to github-actions bot #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the thread-comments feature when users specify a personal access token instead of the generic `GITUHB_TOKEN` Thankfully, we can still identify our generated comments using the action-specific HTML comment embedded in the beginning of the comment text. Note: The HTML comment is only seen for public repositories. For private repos, the comment's body fetched by REST API is in plain text (with HTML syntax removed).
2bndy5
force-pushed
the
allow-user-tokens
branch
from
7cc858b to
f082eac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 99.90% 99.90% -0.01%
==========================================
Files 18 18
Lines 1100 1099 -1
==========================================
- Hits 1099 1098 -1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
shenxianpeng
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the thread-comments feature when users specify a personal access token instead of the generic
GITUHB_TOKENThankfully, we can still identify our generated comments using the action-specific HTML comment embedded in the beginning of the comment text.
Note: The HTML comment is only seen for public repositories. For private repos, the comment's body fetched by REST API is in plain text (with HTML syntax removed).