chore: review CI workflows #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bndy5
force-pushed
the
review-ci
branch
3 times, most recently
from
46043f7 to
aaba6a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 23 23
Lines 1886 1886
=======================================
Hits 1853 1853
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2bndy5
commented
Sep 4, 2025
Contributor
Author
There was a problem hiding this comment.
This enables zizmor per cpp-linter/.github#46
I suppose we could lock the zizmor version with uv.
But most analysis by zizmore is skipped when GH_TOKEN (or --token) is not provided.
uvx zizmor .github/workflows/*.yml
INFO zizmor::registry: skipping impostor-commit: can't run without a GitHub API token
INFO zizmor::registry: skipping ref-confusion: can't run without a GitHub API token
INFO zizmor::registry: skipping known-vulnerable-actions: can't run without a GitHub API token
INFO zizmor::registry: skipping forbidden-uses: audit not configured
INFO zizmor::registry: skipping stale-action-refs: can't run without a GitHub API token
INFO audit: zizmor: 🌈 completed .github\workflows\analyze-workflows.yml
INFO audit: zizmor: 🌈 completed .github\workflows\codeql.yml
INFO audit: zizmor: 🌈 completed .github\workflows\docs.yml
INFO audit: zizmor: 🌈 completed .github\workflows\labeler.yml
INFO audit: zizmor: 🌈 completed .github\workflows\pre-commit.yml
INFO audit: zizmor: 🌈 completed .github\workflows\release-drafter.yml
INFO audit: zizmor: 🌈 completed .github\workflows\release.yml
INFO audit: zizmor: 🌈 completed .github\workflows\stale.yml
INFO audit: zizmor: 🌈 completed .github\workflows\tests.yml
No findings to report. Good job! (19 suppressed)
- adjust CI matrix about tested clang versions and switch back to ubuntu-latest - pin actions to their SHA instead of using their tags - change dependabot updates to monthly check - rewrite release CI (per cpp-linter/.github#41) - explicitly specify permissions needed - add zizmor static analysis
shenxianpeng
approved these changes
Sep 4, 2025
2bndy5
added a commit
that referenced
this pull request
Sep 4, 2025
Some permissions were in adequate after merging #151. This was hard to predict because the permission requirements changed between PR and push events to main.
2bndy5
added a commit
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zizmorfor static analysis of GitHub Actions .github#46)