swap file names in paginated changed files's diff #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenxianpeng
approved these changes
Sep 18, 2024
Contributor
Author
|
The codecov site has been buggy today. There is no summary/response in cpp-linter/cpp-linter-rs#37 PR either. I'll wait until tomorrow. Hopefully, it'll be back in working order. PS - I discovered this when porting the feature to rust. I'm surprised that the unit tests didn't pick this up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 24 24
Lines 1798 1798
=======================================
Hits 1796 1796
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug-fix about changes in #116
When getting changed files for a large diff, I noticed the generated diff from the files' individual patch had the filenames reversed. This only affects changed files that were renamed.