resort to paginated request(s) to get file changes #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include hidden files in CI artifact upload
2bndy5
force-pushed
the
paginated-fallback
branch
from
4a06724 to
895b7e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 23 +1
Lines 1665 1718 +53
=========================================
+ Hits 1665 1718 +53 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
With the new unit tests (modeled from actual HTTP responses), I'm confident this is safe to merge. It would be too much work to create a test condition where we have to parse over 300 file changes just to satisfy this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the paginated JSON responses from Github's REST API to get file changes (with individual diffs) when the full diff is too large for 1 HTTP request/response.
These changes are abstracted from the initial proposal in #115 and solely aims to address cpp-linter/cpp-linter-action#249