abstract api_request() with custom rate-limit headers
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also moves has_more_pages() into rest_api_client.py module
2bndy5
changed the title
api_request() with custom rate-limit headers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
============================================
+ Coverage 84.50% 100.00% +15.49%
============================================
Files 8 21 +13
Lines 697 1506 +809
============================================
+ Hits 589 1506 +917
+ Misses 108 0 -108 ☔ View full report in Codecov by Sentry. |
2bndy5
commented
Apr 25, 2024
Contributor
Author
|
Probably easier if this is merged first before #103 |
shenxianpeng
approved these changes
Apr 27, 2024
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also moves
has_more_pages()into rest_api_client.py module.This is a small abstraction from trying to support gitlab CI (see gitlab PR). It posses no significant API changes.