Skip to content

PR review summary comment content #65

@2bndy5

Description

@2bndy5

Currently a PR review from only clang-tidy will output:


Cpp-linter Review

No objections from clang-format.

Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +17,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..2591c48 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -11 +11 @@ class Dummy {
-    void *not_useful(char *str){useless = str;}
+        auto not_useful(char* str) -> void* { useless = str; }

Have any feedback or feature suggestions? Share it here.


However, we don't need to alert users about info that is not requested. In this example, clang-format suggestions were not requested, but it still shows:

No objections from clang-format.

Furthermore, the full patch is included for any requested changes. This is because the suggested changes will not always fit within the diff. I have included the full patch in every review where changes are requested from the specified clang tool, even if all suggestions fit within the diff.

Proposal

Remove the "No objections from <clang-tool>" line for reviews with requested changes when the <clang-tool> was not enabled for PR reviews. Note, this info is still relevant for reviews in which the changes are approved.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions