Skip to content

New inputs to provide finite control of thread-comments #34

@2bndy5

Description

@2bndy5

See cpp-linter/cpp-linter-action#158 (comment)

  • I think we can augment the thread-comments input, where

    • true would be delete and post anew (the current behavior)
    • false disable feature (as has always been)
    • update would be to re-use existing comment or create a new if none exists (this is the new suggestion).
  • A no-lgtm option would be needed to prevent the new "LGTM" comment from getting posted (as was the behavior before v1.6.0). I have to look at the history, but I think we also used to leave an outdated comment in the thread when checks passed. We should delete our previous PR comment if checks passed and an old one exists. @shenxianpeng Do you object to making this no-lgtm option default to true?


If I have the time, this would also be a good opportunity to make sure we check the full list of PR comments instead of only the first 30 (or whatever the REST API payload limit is).

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions