-
Notifications
You must be signed in to change notification settings - Fork 0
Add transparent background banner #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f09408b to
e9f8bbf
Compare
|
Did you want it to be the same dimensions? I can help. |
|
I think the README is actually doing some manipulation to the image: Line 2 in e9f8bbf
|
|
Yes, me too. I'll try to find a better width and height. it should be too wide for mobile. |
|
I think the min width used should be 320 (going off of common dimensions listed for portrait mode on various phones - see this site) Then the height would be dependent on the image's aspect ratio. |
|
I think github supports the <img src="/assets/readme-banner.png" min-width="320" min-height="88" alt="cpp-linter_brand_logo" /> |
|
In order to view the result in the local environment, I moved readme-banner.png to the profile folder and remove the assets folder. I hope the image is displayed as big as possible, so I change to width to 400 and remove height from README.md, it looks well on desktop and mobile. |
|
Using my above suggestion, Using a strict |
|
Updated with your suggestion, it looks great 👍 |
2bndy5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So pretty! 😍
|
Oh NO, it seems I can not change the refer structure |
|
It works now. |
|
I think the current banner on the org overview page is a bit larger than I expected, and users may be drawn to the banner rather than the text/repositories below. |
|
You could scale down the image. That's why it was so big to begin with. I needed something that could be scaled down because scaling an image up produced distortion. |
resolves #6 - includes changes to satisfy warnings/errors raised by zizmor


Trying to replace the current readme-banner which does not have a transparent background, so in the dark theme, it displays a white background.