chore: switch to separate docs deployment job #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the documentation deployment workflows to use a separate deployment job with GitHub's official deployment action for improved security and provenance.
- Splits build and deployment into separate jobs for better security isolation
- Replaces custom deployment actions with the official
actions/deploy-pagesaction - Adds proper GitHub Pages permissions and environment configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/sphinx.yml | Separates Sphinx docs build from deployment, uses official deploy-pages action |
| .github/workflows/mkdocs.yml | Separates MkDocs build from deployment, removes git configuration and uses official deploy-pages action |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shenxianpeng
approved these changes
Sep 7, 2025
2bndy5
force-pushed
the
gh-pages-deployment
branch
from
fe8b285 to
ea52ebb
Compare
Contributor
Author
|
going to try to test this in cpp-linter-action and clang-tools-pip first |
- uses actions/deploy-pages (for better provenance) - uses a separate conditional job to deploy docs (for a clean env with limited attack surface) - uses action/upload-pages-artifact (for preparing artifact in expected format) - an input option with a default value is not required
2bndy5
force-pushed
the
gh-pages-deployment
branch
from
6cc2564 to
608dfd0
Compare
Contributor
Author
|
this works in
|
2bndy5
added a commit
to cpp-linter/cpp-linter
that referenced
this pull request
Sep 7, 2025
now that it uses uv in reusable workflow see also cpp-linter/.github#52
This was referenced Sep 7, 2025
2bndy5
added a commit
to cpp-linter/cpp-linter
that referenced
this pull request
Sep 7, 2025
now that it uses uv in reusable workflow see also cpp-linter/.github#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.