core: Capture stderr in CLIDriver even if capture_output is False

cpitclaudel · cpitclaudel · commit 55340d4e61a5 · 2024-03-04T00:28:17.000+01:00
We need to capture stderr to print the error when the driver fails.
diff --git a/alectryon/core.py b/alectryon/core.py
@@ -488,8 +488,9 @@ def run_cli(self, working_directory=None, capture_output=True, more_args=()):
                *self.CLI_ARGS, *self.user_args, *more_args]
         self._debug_start(cmd)
         p = subprocess.run(cmd, cwd=working_directory,
-                           capture_output=capture_output, check=False,
-                           encoding=self.CLI_ENCODING)
+                           stderr=subprocess.PIPE,
+                           stdout=subprocess.PIPE if capture_output else None,
+                           check=False, encoding=self.CLI_ENCODING)
         if p.returncode != 0:
             MSG = "Driver {} ({}) exited with code {}:\n{}"
             raise ValueError(MSG.format(self.NAME, self.binpath, p.returncode,
