Skip to content

docs: Add information about cursor width#151

Merged
coder3101 merged 1 commit intocpeditor:hugofrom
sonulohani:feat_cursor_width_doc
Mar 13, 2021
Merged

docs: Add information about cursor width#151
coder3101 merged 1 commit intocpeditor:hugofrom
sonulohani:feat_cursor_width_doc

Conversation

@sonulohani
Copy link
Copy Markdown
Contributor

@sonulohani sonulohani commented Mar 13, 2021

Copy link
Copy Markdown
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but @StudyingFather or @ChungZH could you please add this to Chinese translation.

@sonulohani sonulohani force-pushed the feat_cursor_width_doc branch from e0ed4f4 to 3ca5501 Compare March 13, 2021 05:02
@coder3101 coder3101 merged commit f48c906 into cpeditor:hugo Mar 13, 2021
@sonulohani sonulohani deleted the feat_cursor_width_doc branch March 13, 2021 10:10
@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

The zh version shouldn't be updated. Otherwise, it won't be marked as unfinished.

@coder3101
Copy link
Copy Markdown
Member

The zh version shouldn't be updated. Otherwise, it won't be marked as unfinished.

Do we find it updated or not based on commit history?

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

Do we find it updated or not based on commit history?

Based on page title, update time, and the "translated" param.

Translated or not:

  • If the "translated" param is set in the Markdown frontmatter, it is used.
  • Otherwise, we check whether the page title is the same as the English version.

If it's translated, we use the last updated time to check whether it's updated or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants