Skip to content

Change the command-line option --no-hot-exit to --no-restore-session.#947

Merged
coder3101 merged 9 commits intov7.0from
fix-#928
Aug 4, 2021
Merged

Change the command-line option --no-hot-exit to --no-restore-session.#947
coder3101 merged 9 commits intov7.0from
fix-#928

Conversation

@ChungZH
Copy link
Copy Markdown
Member

@ChungZH ChungZH commented Aug 1, 2021

Description

Related Issues / Pull Requests

close #928

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@ChungZH ChungZH marked this pull request as draft August 1, 2021 10:36
@ouuan ouuan changed the base branch from master to v7.0 August 1, 2021 10:45
@ChungZH ChungZH marked this pull request as ready for review August 1, 2021 10:54
ChungZH and others added 2 commits August 1, 2021 10:54
…/fix-#928

style: format codes for ChungZH on refs/heads/fix-#928
@swiftqwq
Copy link
Copy Markdown
Member

swiftqwq commented Aug 1, 2021

Should we add a deprecated warning for --no-hot-exit?

@coder3101
Copy link
Copy Markdown
Member

Should we add a deprecated warning for --no-hot-exit?

We will directly remove it since it's going in 7.0

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Aug 1, 2021

Should we add a deprecated warning for --no-hot-exit?

I think users seldom use this option, and it's even more unlikely that the option is passed by a script and breaks the workflow. So it's not very breaking, hence a deprecated warning is not necessary.

coder3101
coder3101 previously approved these changes Aug 4, 2021
@coder3101 coder3101 requested a review from ouuan August 4, 2021 05:52
@coder3101 coder3101 enabled auto-merge (squash) August 4, 2021 05:52
@coder3101 coder3101 merged commit 998b534 into v7.0 Aug 4, 2021
@coder3101 coder3101 deleted the fix-#928 branch August 4, 2021 07:01
ouuan added a commit that referenced this pull request Feb 13, 2024
* Change the command-line option --no-hot-exit to --no-restore-session.

* Change the command-line option --no-hot-exit to --no-restore-session.

* update

* style: format codes

* style: format codes

Co-authored-by: Yufan You <[email protected]>
Co-authored-by: ChungZH <[email protected]>
ouuan added a commit that referenced this pull request Feb 13, 2024
* fix!: change --no-hot-exit to --no-restore-session (#947)

* Change the command-line option --no-hot-exit to --no-restore-session.

* Change the command-line option --no-hot-exit to --no-restore-session.

* update

* style: format codes

* style: format codes

Co-authored-by: Yufan You <[email protected]>
Co-authored-by: ChungZH <[email protected]>

* chore!: remove all legacy settings

* build(QtFindReplaceDialog): bump cmake_minimum_required to 3.5

* chore!: update app name and config file paths

closes #925

* chore: change the log path

closes #926

* docs: update changelog

---------

Co-authored-by: Flex Zhong <[email protected]>
Co-authored-by: ChungZH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the command-line option --no-hot-exit to --no-restore-session.

4 participants