fix: correct time measurement when test cases are large on Windows#938
Merged
fix: correct time measurement when test cases are large on Windows#938
Conversation
coder3101
approved these changes
Jul 25, 2021
swiftqwq
approved these changes
Jul 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cac37ff uses a temporary file as the stdin of the process instead of using
QProcess::write, which prevents the main thread from blocking when writing large data to the process on Windows.1b4d607 is a failed attempt to fix this problem, but it does make the time measurement more accurate on all platforms.
e673712 is another failed attempt which uses QThreadPool.
Related Issues / Pull Requests
This fixes #789.
How Has This Been Tested?
On Arch Linux and Windows 10.
Checklist
oldattribute is updated or it is resolved in SettingsUpdater.tr()orQCoreApplication::translate().