Skip to content

fix: correct time measurement when test cases are large on Windows#938

Merged
coder3101 merged 4 commits intomasterfrom
accurate-time
Jul 25, 2021
Merged

fix: correct time measurement when test cases are large on Windows#938
coder3101 merged 4 commits intomasterfrom
accurate-time

Conversation

@ouuan
Copy link
Copy Markdown
Member

@ouuan ouuan commented Jul 25, 2021

Description

cac37ff uses a temporary file as the stdin of the process instead of using QProcess::write, which prevents the main thread from blocking when writing large data to the process on Windows.

1b4d607 is a failed attempt to fix this problem, but it does make the time measurement more accurate on all platforms.

e673712 is another failed attempt which uses QThreadPool.

Related Issues / Pull Requests

This fixes #789.

How Has This Been Tested?

On Arch Linux and Windows 10.

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

@coder3101 coder3101 enabled auto-merge (squash) July 25, 2021 06:52
@coder3101 coder3101 merged commit f7df7eb into master Jul 25, 2021
@coder3101 coder3101 deleted the accurate-time branch July 25, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small test cases take nearly the same time as large test cases when running together on Windows

3 participants