Conversation
coder3101
changed the title
|
The "Get it from" is invisible with a height of 28px. Do we need that line? |
Not necessary but why do we keep it along with downloads, sponsors and other badges. I suggest we put it in a new line below so it is visible completely and centered to draw focus of visitors. |
|
Something like this: |
|
Yeah, but I'm wondering why we should draw attention to it. The badge somehow sounds like "you need to get it from snap store", but actually the snap installation method is targeted at only a few users. |
|
We set the |
|
I think the badges in the version table are enough. |
Fine, remove the "Get it from Snap store" badge, update language READMEs and approve. |
|
I reverted the "fix version" part by mistake... |
However, it's a good example that we should do one thing per commit. |
* init README_zh-TW.md * add DONATE_zh-TW * add language link for Chinese Traditional (Taiwan) * finish translating CONTRIBUTION.md * add translation for conventional commit * Add link for Chinese Simplified (China) * Add link to Chinese Traditional * Fix snap version and update README (#932) * build(snap): fix version by adding git (#933) * Add snap * Add link for zh-TW in README and edit the link text to 正體中文 * Change the link to zh_tw version on cpeditor.org * Add zh-TW in the "files" part in ".all-contributorsrc: file" * Add zh-TW description in dist/linux/cpeditor.desktop and cmake/cpeditor.appdata.xml.in Co-authored-by: Ashar <[email protected]> Co-authored-by: Yufan You <[email protected]>
3 participants
No description provided.