docs: add Chinese Traditional (Taiwan) by toto6038 · Pull Request #930 · cpeditor/cpeditor

toto6038 · 2021-07-14T17:13:33Z

Description

Translate README.md, CONTRIBUTING.md, DONATE.md into Chinese Traditional (Taiwan), and add the link to zh-TW in original README.md

Related Issues / Pull Requests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
If needed, I have opened a pull request or an issue to update the documentation.
If these changes are notable, they are documented in CHANGELOG.md.

Additional text

README.md

ouuan · 2021-07-15T01:00:54Z

If you are willing to translate the website, I can prepare the structure now so that we can link to it in this PR.

toto6038 · 2021-07-15T04:36:34Z

If you are willing to translate the website, I can prepare the structure now so that we can link to it in this PR.

I'm glad to do that.

ouuan · 2021-07-15T09:13:47Z

I've opened cpeditor/cpeditor.github.io#198, and you need to accept the membership invitation of @cpeditor to push to that branch.

neko-para · 2021-07-15T09:13:58Z

Will you translate the UI of the excutable? (just wondering)

ouuan · 2021-07-15T09:19:11Z

Will you translate the UI of the excutable? (just wondering)

I think the UI translation could be in another PR because it doesn't affect the translation of the documentation. However, with the translation of the website, we should link to translated pages in the docs.

coder3101 · 2021-07-15T09:27:10Z

Will you translate the UI of the excutable? (just wondering)

Yes. I think before translating the website, the application should be translated, it is going the other way around.

Ideal ordering should be

Translate Application
Translate README/CONTRIBUTE etc
Translate the website

toto6038 · 2021-07-15T10:41:38Z

Comparing to website or introduction, I'm less confident in translating UI strings. However I can still try my best to do it.

toto6038 · 2021-07-17T14:04:36Z

I currently proceed to do UI localization. Do I have to duplicate and modify the existing file in translation directory, or is there a way to get the English ts file?

ouuan · 2021-07-17T14:21:20Z

I currently proceed to do UI localization. Do I have to duplicate and modify the existing file in translation directory, or is there a way to get the English ts file?

You can use the zh_TW-app branch. And you need to accept the membership invitation in your email inbox or at https://github.com/cpeditor, otherwise, you won't have permission to push to that branch.

ouuan · 2021-07-17T14:24:44Z

BTW, do you know anyone that could help review these translations? It will be better if another competitive programmer from Taiwan could review these translations.

toto6038 · 2021-07-18T14:39:43Z

Thanks for what you've done. I can find someone to review the translation.

toto6038

finished review

coder3101 · 2021-07-18T14:47:25Z

You should update the PR by merging master branch to it. Readme was updated to include snap version in release table.

toto6038 · 2021-07-19T07:18:58Z

PR updated

README_ru-RU.md

ouuan

Link to the zh_tw version of cpeditor.org

ouuan · 2021-07-20T06:23:38Z

Do you want to work on cpeditor/cpeditor.github.io#198 now or later? I can merge it now if you want to create a new PR later.

toto6038 · 2021-07-20T07:33:41Z

The translation of website will be worked on later.

swiftqwq · 2021-07-20T09:11:21Z

@toto6038 please update the files part in .all-contributorsrc.

toto6038 · 2021-07-20T11:07:01Z

.all-contributorsrc: file edited

ouuan · 2021-07-20T11:52:07Z

dist/linux/cpeditor.desktop and cmake/cpeditor.appdata.xml.in

…or.appdata.xml.in

ouuan

LGTM, thanks!

toto6038 added 5 commits July 14, 2021 02:22

init README_zh-TW.md

b11b501

add DONATE_zh-TW

2e23079

add language link for Chinese Traditional (Taiwan)

672e07a

finish translating CONTRIBUTION.md

9f99e40

add translation for conventional commit

d71df57

toto6038 mentioned this pull request Jul 14, 2021

Translate to Chinese Traditional (Taiwan) #929

Closed

5 tasks

ouuan reviewed Jul 15, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

toto6038 added 2 commits July 15, 2021 12:28

Add link for Chinese Simplified (China)

c02f415

Add link to Chinese Traditional

53a8fb6

toto6038 commented Jul 18, 2021

View reviewed changes

coder3101 and others added 4 commits July 19, 2021 01:27

Fix snap version and update README (cpeditor#932)

191c3bd

build(snap): fix version by adding git (cpeditor#933)

b16ea88

Merge remote-tracking branch 'upstream/master' into l10n-tw

dc4d566

Add snap

bcddf1a

neko-para reviewed Jul 19, 2021

View reviewed changes

README_ru-RU.md Show resolved Hide resolved

toto6038 added 2 commits July 19, 2021 22:54

Add link for zh-TW in README and edit the link text to 正體中文

38627be

Merge remote-tracking branch 'origin/l10n-tw' into l10n-tw

3562ac8

neko-para previously approved these changes Jul 20, 2021

View reviewed changes

coder3101 previously approved these changes Jul 20, 2021

View reviewed changes

ouuan requested changes Jul 20, 2021

View reviewed changes

Change the link to zh_tw version on cpeditor.org

c60bec0

toto6038 dismissed stale reviews from coder3101 and neko-para via c60bec0 July 20, 2021 05:30

toto6038 requested a review from ouuan July 20, 2021 05:32

Add zh-TW in the "files" part in ".all-contributorsrc: file"

09db13a

Add zh-TW description in dist/linux/cpeditor.desktop and cmake/cpedit…

96343c9

…or.appdata.xml.in

ouuan approved these changes Jul 21, 2021

View reviewed changes

coder3101 approved these changes Jul 21, 2021

View reviewed changes

coder3101 merged commit 82ae1ca into cpeditor:master Jul 21, 2021

Uh oh!

Conversation

toto6038 commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues / Pull Requests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

Additional text

Uh oh!

Uh oh!

ouuan commented Jul 15, 2021

Uh oh!

toto6038 commented Jul 15, 2021

Uh oh!

ouuan commented Jul 15, 2021

Uh oh!

neko-para commented Jul 15, 2021

Uh oh!

ouuan commented Jul 15, 2021

Uh oh!

coder3101 commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

toto6038 commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

toto6038 commented Jul 17, 2021

Uh oh!

ouuan commented Jul 17, 2021

Uh oh!

ouuan commented Jul 17, 2021

Uh oh!

toto6038 commented Jul 18, 2021

Uh oh!

toto6038 left a comment

Choose a reason for hiding this comment

Uh oh!

coder3101 commented Jul 18, 2021

Uh oh!

toto6038 commented Jul 19, 2021

Uh oh!

Uh oh!

ouuan left a comment

Choose a reason for hiding this comment

Uh oh!

ouuan commented Jul 20, 2021

Uh oh!

toto6038 commented Jul 20, 2021

Uh oh!

swiftqwq commented Jul 20, 2021

Uh oh!

toto6038 commented Jul 20, 2021

Uh oh!

ouuan commented Jul 20, 2021

Uh oh!

ouuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toto6038 commented Jul 14, 2021 •

edited

Loading

coder3101 commented Jul 15, 2021 •

edited

Loading

toto6038 commented Jul 15, 2021 •

edited

Loading