Skip to content

feat: auto re-compile checker when changed#898

Merged
coder3101 merged 11 commits intomasterfrom
recompile-checker
Aug 6, 2021
Merged

feat: auto re-compile checker when changed#898
coder3101 merged 11 commits intomasterfrom
recompile-checker

Conversation

@swiftqwq
Copy link
Copy Markdown
Member

@swiftqwq swiftqwq commented Jun 28, 2021 •
edited by ouuan
Loading

Description

Check the hash of checker's source file to auto re-compile it before run.

Related Issues / Pull Requests

Fixes #843

Motivation and Context

How Has This Been Tested?

macOS 12.0

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@swiftqwq swiftqwq requested a review from ouuan June 28, 2021 08:29
@ouuan
Copy link
Copy Markdown
Member

ouuan commented Jun 28, 2021

Now the checker won't recompile when running a single test case. This can be fixed by adding the same logic in MainWindow::runTestCase, but I think it will be better if the recompilation is handled in Checker. This may require some refactoring in Checker.

@swiftqwq swiftqwq marked this pull request as draft June 28, 2021 10:58
@swiftqwq swiftqwq marked this pull request as ready for review June 29, 2021 01:11
@ouuan ouuan force-pushed the recompile-checker branch from 335e21b to ea04515 Compare June 29, 2021 02:29
@ouuan ouuan added the awaiting for translation:RU Associated PR is waiting for russian translations to be updated label Jun 29, 2021
@ouuan ouuan requested a review from a team June 29, 2021 02:37
@coder3101 coder3101 merged commit acf28a8 into master Aug 6, 2021
@coder3101 coder3101 deleted the recompile-checker branch August 6, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

@ouuan ouuan ouuan approved these changes

Assignees

No one assigned

Labels

awaiting for translation:RU Associated PR is waiting for russian translations to be updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support update/remove custom checkers

3 participants

@swiftqwq @ouuan @coder3101