Skip to content

ci(release): include LLVM in the winlibs release#878

Merged
ouuan merged 3 commits intov6.9from
winlibs-llvm
Jun 17, 2021
Merged

ci(release): include LLVM in the winlibs release#878
ouuan merged 3 commits intov6.9from
winlibs-llvm

Conversation

@ouuan
Copy link
Copy Markdown
Member

@ouuan ouuan commented Jun 17, 2021

Description

Include LLVM in the winlibs release.

Related Issues / Pull Requests

This could be an out-of-box solution for #824.

Motivation and Context

At least on my Windows, the clangd downloaded on LLVM official website doesn't recognize <bits/stdc++.h> while the one in winlibs does.

How Has This Been Tested?

https://github.com/ouuan/cpeditor/releases/tag/0.20210617.3

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

ouuan added 3 commits June 17, 2021 11:03
1.  I found that using the clangd in winlibs solves the `<bits/stdc++.h>`
    issue, so we can include LLVM in the winlibs release.
2.  I also found that we shouldn't rely on the "latest" release of
    winlibs, because sometimes older versions of GCC/LLVM/MinGW can be a
    "newer" version of winlibs, because the winlibs repo has no commits,
    which makes the "latest" release time-based instead of version-based.
@ouuan ouuan enabled auto-merge (squash) June 17, 2021 04:32
@ouuan ouuan merged commit 3e1deb5 into v6.9 Jun 17, 2021
@ouuan ouuan deleted the winlibs-llvm branch June 17, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants