Skip to content

feat: associate files to be opened in cpeditor#860

Merged
swiftqwq merged 11 commits intomasterfrom
associate-files
Jun 12, 2021
Merged

feat: associate files to be opened in cpeditor#860
swiftqwq merged 11 commits intomasterfrom
associate-files

Conversation

@swiftqwq
Copy link
Copy Markdown
Member

@swiftqwq swiftqwq commented Jun 6, 2021 •
edited
Loading

Description

Update desktop file(Linux) and Inno Setup file(Windows) to associate files to open in cpeditor.

Related Issues / Pull Requests

Closes #855

Motivation and Context

How Has This Been Tested?

https://github.com/swift-zym/cpeditor/releases/tag/0.0.8

Screenshots (if appropriate)

image

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@swiftqwq
Copy link
Copy Markdown
Member Author

swiftqwq commented Jun 6, 2021

I don't have a windows device by now so I can't test it, can you help me to test it @ouuan ?

@swiftqwq swiftqwq requested review from coder3101 and ouuan June 6, 2021 14:18
@swiftqwq swiftqwq marked this pull request as draft June 7, 2021 08:02
@swiftqwq swiftqwq marked this pull request as ready for review June 7, 2021 08:47
@swiftqwq swiftqwq changed the title Associate files Associate files to open in cpeditor Jun 7, 2021
ouuan
ouuan reviewed Jun 7, 2021
View reviewed changes
@ouuan ouuan changed the title Associate files to open in cpeditor feat: associate files to be opened in cpeditor Jun 7, 2021
@swiftqwq swiftqwq requested a review from ouuan June 8, 2021 12:05
@swiftqwq
Copy link
Copy Markdown
Member Author

swiftqwq commented Jun 12, 2021

It seems work well on Windows and Linux now.

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Jun 12, 2021

I'm not sure whether it works on Windows correctly. I don't have a clean Windows environment, so I tried to clean my environment and it didn't seem to work. I'm not sure whether it's caused by my incorrect way to clean the environment.

@swift-zym Did you test it in a clean Windows environment?

@swiftqwq
Copy link
Copy Markdown
Member Author

swiftqwq commented Jun 12, 2021

I'm not sure whether it works on Windows correctly. I don't have a clean Windows environment, so I tried to clean my environment and it didn't seem to work. I'm not sure whether it's caused by my incorrect way to clean the environment.

@swift-zym Did you test it in a clean Windows environment?

I didn't, I find the problem now...

@swiftqwq
Copy link
Copy Markdown
Member Author

swiftqwq commented Jun 12, 2021

Now I've test it in a clean Windows environment and it works well.

ouuan
ouuan approved these changes Jun 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ouuan ouuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested on my Windows, but the diff looks good and @swift-zym has tested it.

@coder3101
Copy link
Copy Markdown
Member

coder3101 commented Jun 12, 2021

Can you provide a installer build from this branch, so that I can test and approve. The URL above gives 404

@swiftqwq
Copy link
Copy Markdown
Member Author

swiftqwq commented Jun 12, 2021

Can you provide a installer build from this branch, so that I can test and approve. The URL above gives 404

https://github.com/swift-zym/cpeditor/releases/tag/0.0.8

@swiftqwq swiftqwq enabled auto-merge (squash) June 12, 2021 08:13
coder3101
coder3101 approved these changes Jun 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@swiftqwq swiftqwq merged commit f4025b9 into master Jun 12, 2021
@swiftqwq swiftqwq deleted the associate-files branch June 12, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

@ouuan ouuan ouuan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Associate source files to open in cpeditor

3 participants

@swiftqwq @ouuan @coder3101