@ouuan @coder3101 As it will be a quite huge work, I'd like to know yours opinions.

Up to now, almost all previous features have been finished.

plans todo:

• add a config to remove labels widget in SettingsWrapper's FormLayout
• allow adding more specialized actions for Object
• fix warning QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
• allow restricting keys of Object
• allow Object to have non-empty default value
• fix immediatelyApply

fix warning QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout

#541 (comment)

Here comes a problem. QVariant cannot store function. It'll be hard to solve adding more specialized actions for Object by param.
Maybe add an extra key in settings info to store functions(e.g. QMap<QString, std::function<QVariant(QVariant)>>), and onApply could also use it.

I think it's not a good idea to store methods in json. Some of actions are quite long(e.g. import snippets from file), and you have to write all these things in a json string. We could add an extra source code to store all these functions, and let py link them to setting info.

After all, we can just include a header in settinginfo.cpp and call them directly in the lambda py generated.

Yes, vcpkg is a general package manager for c++. These changes will certainly need some changes in release pipeline as well. Like does vcpkg builds as shared library? If yes we need to add to exe bundle.

Yes, vcpkg is a general package manager for c++. These changes will certainly need some changes in release pipeline as well. Like does vcpkg builds as shared library? If yes we need to add to exe bundle.

Yes, it is a dll. I'll add it to the bundle later. I'd like to check the deb first.

Actually I'm wondering why there isn't a script to build the deb? We write every commands in the workflow.

I've add the shared library on windows to the exe bundle.

We should merge master to this branch, and check if all release components like Deb, exe, DMG are working. Take help from @swift-zym he has macOS.

Why there is target_link_libraries(diff_match_patch PRIVATE Qt5::Core) in CMakeLists.txt? After auto merge it come up, but I cannot find the reason.

Why there is target_link_libraries(diff_match_patch PRIVATE Qt5::Core) in CMakeLists.txt? After auto merge it come up, but I cannot find the reason.

I tried the merge and there's a conflict in CMakeLists.txt. Maybe you incorrectly resolved it.

I reset to previous and find out that it has been there before. It may come from older commit.

This code is from f52c378

After all, we have solved it. @ouuan Do you know anything about that AUR build test? It breaks again.

@ouuan Do you know anything about that AUR build test? It breaks again.

You can try giving gen_settings a separate CMakeLists.txt.

This looks strange. src/Settings/CMakeLists.txt is supposed to build the whole src/Settings directory. I suggest moving genSettings.cpp to a new directory src/Settings/GenSettings or somewhere else.

Maybe src/Settings/gen?

@coder3101 After some talks with @ouuan, he suggests me to revert and create better-described commits for those changed files. I think it's good and I'll do it later.

I'll create a new PR and this PR could be the logs.

Close this in favor of #955.