This icon sure looks more consistent with macOS and apple design, the question is, should we have different icon for different OS? What is your opinion @ouuan on this?

The app icon in the Dock looks good, but do we need to change the in-app icon (which is displayed on the home page of the preferences window and some other places)? @swift-zym What do you think?

The app icon in the Dock looks good, but do we need to change the in-app icon (which is displayed on the home page of the preferences window and some other places)? @swift-zym What do you think?

In my opinion changing launcher icon is enough. This will also remove those conditional OS macros from code which makes it looks like we have different icon for different OS.

Please share your opinion @swift-zym ?

@coder3101 @ouuan I agree that we needn't change the in-app icon,but I think we should keep the code in appwindow.cpp and main.cpp, it will change the dock icon when running.

@allcontributors add @swift-zym as a contributor for code and design.

Does the old icon not at all used by macOS now?

Does the old icon not at all used by macOS now?

5fb109e