Conversation
|
Classic confinement request has been approved. @ouuan can you add the workflow for stable release? I have added for edge channel, you can add for stable channel. And we can re tag to publish on snapstore. |
|
This is complete, I will test it in a fork (Just build and not publish the package) and put the URL below. Upon merge to master, a edge snap package will be released and I will manually publish the stable package for now, in next release that should be done by the workflow as well. EDIT: 6.9.2 should be released soon so I don't need to publish it manually |
|
Here is a run for "Snap Release" See publishing has failed because of missing store login data. |
There's no secret in pull requests. I'm not sure about workflow_dispatch. |
Release AUR was modified to become Release Snapcraft. Workflow dispatch came from there. I have added secret to this repository, not in my fork so it failed to push, I don't wanted to push the release from the fork. |
|
I didn't notice that it was in your fork and didn't realize "See publishing has failed because of missing store login data" was an explaination 😅 |
|
There has been a question for me for a long time. If I know exactly nothing about the tech used in a certrain PR, what should I do if I'm required to review it? 🤔 |
In such cases, I am the last to approve, if the PR is pending merge because of my review and someone has already reviewed and if requested, appropriate changes have been brought. I just give a bird eye view about the changes and check for things that I understand and provide any feedback if required and approve. |
|
I changed the base to v6.9. |
Description
Adds CD pipeline to push automatically on edge snap channel on every push to master, on release of new tag, push the stable build to snap stable channel.
Related Issues / Pull Requests
Fixes #456
Motivation and Context
Updating and managing of AppImage is not widely known, snaps on the other hand is backed by canonical and ships by default on Ubuntu, making it easier to install cpeditor on those platform, snaps can also be installed on any other Linux distribution.
How Has This Been Tested?
Tested in Ubuntu focal VM
Screenshots (if appropriate)
Checklist
oldattribute is updated or it is resolved in SettingsUpdater.tr()orQCoreApplication::translate().Additional text