Skip to content

ci(snap): add pipelines for publishing snap packages#835

Merged
ouuan merged 2 commits intov6.9from
snapcraft
Jun 23, 2021
Merged

ci(snap): add pipelines for publishing snap packages#835
ouuan merged 2 commits intov6.9from
snapcraft

Conversation

@coder3101
Copy link
Copy Markdown
Member

@coder3101 coder3101 commented May 22, 2021

Description

Adds CD pipeline to push automatically on edge snap channel on every push to master, on release of new tag, push the stable build to snap stable channel.

Related Issues / Pull Requests

Fixes #456

Motivation and Context

Updating and managing of AppImage is not widely known, snaps on the other hand is backed by canonical and ships by default on Ubuntu, making it easier to install cpeditor on those platform, snaps can also be installed on any other Linux distribution.

How Has This Been Tested?

Tested in Ubuntu focal VM

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@coder3101 coder3101 changed the title ci(snap): Base structure for snap CD pipelines ci(snap): Add pipelines for publishing snap packages May 22, 2021
@ouuan ouuan added the work in progress The work has been started and is in progress. label May 29, 2021
@coder3101
Copy link
Copy Markdown
Member Author

coder3101 commented Jun 16, 2021

Classic confinement request has been approved.

@ouuan can you add the workflow for stable release? I have added for edge channel, you can add for stable channel.

And we can re tag to publish on snapstore.

@coder3101 coder3101 removed the work in progress The work has been started and is in progress. label Jun 19, 2021
@coder3101
Copy link
Copy Markdown
Member Author

coder3101 commented Jun 19, 2021

This is complete, I will test it in a fork (Just build and not publish the package) and put the URL below.

Upon merge to master, a edge snap package will be released and I will manually publish the stable package for now, in next release that should be done by the workflow as well.

EDIT: 6.9.2 should be released soon so I don't need to publish it manually

@coder3101
Copy link
Copy Markdown
Member Author

Here is a run for "Snap Release"

https://github.com/coder3101/cpeditor/runs/2867461761?check_suite_focus=true

See publishing has failed because of missing store login data.

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Jun 20, 2021

Here is a run for "Snap Release"

coder3101/cpeditor/runs/2867461761?check_suite_focus=true

See publishing has failed because of missing store login data.

There's no secret in pull requests. I'm not sure about workflow_dispatch.

@coder3101
Copy link
Copy Markdown
Member Author

There's no secret in pull requests. I'm not sure about workflow_dispatch.

Release AUR was modified to become Release Snapcraft. Workflow dispatch came from there.

I have added secret to this repository, not in my fork so it failed to push, I don't wanted to push the release from the fork.

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Jun 20, 2021

I didn't notice that it was in your fork and didn't realize "See publishing has failed because of missing store login data" was an explaination 😅

@neko-para
Copy link
Copy Markdown
Contributor

There has been a question for me for a long time. If I know exactly nothing about the tech used in a certrain PR, what should I do if I'm required to review it? 🤔
I'm wondering if it is necessary for pr to require two reviewers.

@coder3101
Copy link
Copy Markdown
Member Author

There has been a question for me for a long time. If I know exactly nothing about the tech used in a certrain PR, what should I do if I'm required to review it? thinking
I'm wondering if it is necessary for pr to require two reviewers.

In such cases, I am the last to approve, if the PR is pending merge because of my review and someone has already reviewed and if requested, appropriate changes have been brought. I just give a bird eye view about the changes and check for things that I understand and provide any feedback if required and approve.

@coder3101 coder3101 requested review from a team, neko-para and ouuan and removed request for a team, neko-para, ouuan and swiftqwq June 20, 2021 13:41
@coder3101 coder3101 requested review from a team, neko-para, ouuan and swiftqwq and removed request for a team, neko-para, ouuan and swiftqwq June 20, 2021 13:41
@ouuan ouuan changed the base branch from master to v6.9 June 21, 2021 13:16
@ouuan
Copy link
Copy Markdown
Member

ouuan commented Jun 21, 2021

I changed the base to v6.9.

@coder3101 coder3101 requested review from neko-para and swiftqwq June 22, 2021 03:59
@coder3101 coder3101 enabled auto-merge (squash) June 22, 2021 04:00
@ouuan ouuan disabled auto-merge June 23, 2021 00:48
@ouuan ouuan changed the title ci(snap): Add pipelines for publishing snap packages ci(snap): add pipelines for publishing snap packages Jun 23, 2021
@ouuan ouuan merged commit 3e273d7 into v6.9 Jun 23, 2021
@ouuan ouuan deleted the snapcraft branch June 23, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload to snap store

3 participants