Skip to content

feat: update full-sreen state when WindowState changes#833

Merged
ouuan merged 1 commit intomasterfrom
update-fullscreen-on-statechange
May 16, 2021
Merged

feat: update full-sreen state when WindowState changes#833
ouuan merged 1 commit intomasterfrom
update-fullscreen-on-statechange

Conversation

@ouuan
Copy link
Copy Markdown
Member

@ouuan ouuan commented May 15, 2021

Description

Update the full-screen state when the window state is changed without triggering the actionFullScreen action.

How Has This Been Tested?

In i3-wm, tested with Meta+F.

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Update the full-screen state when the window state is changed without
triggering the actionFullScreen action. For example, when the window is
made full-screen by the system window manager.
@ouuan ouuan requested review from coder3101 and sonulohani May 15, 2021 16:26
@ouuan ouuan enabled auto-merge (squash) May 15, 2021 16:26
Copy link
Copy Markdown
Contributor

@sonulohani sonulohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ouuan ouuan merged commit bebe1da into master May 16, 2021
@ouuan ouuan deleted the update-fullscreen-on-statechange branch May 16, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants