Skip to content

Auto unchecked accepted testcase#797

Merged
coder3101 merged 6 commits intomasterfrom
auto-unchecked-accepted-testcase
Mar 13, 2021
Merged

Auto unchecked accepted testcase#797
coder3101 merged 6 commits intomasterfrom
auto-unchecked-accepted-testcase

Conversation

@neko-para
Copy link
Copy Markdown
Contributor

@neko-para neko-para commented Mar 13, 2021

Description

Allow editor auto uncheck the accepted testcases.
Add an option for it.
Add Chinese translation.

Related Issues / Pull Requests

Closes #734

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

Change setting category 'Empty Test Cases' to 'Test Cases'.
Add Chinese translations.
@neko-para neko-para requested a review from coder3101 March 13, 2021 02:21
@neko-para neko-para requested a review from sonulohani March 13, 2021 03:59
Copy link
Copy Markdown
Contributor

@sonulohani sonulohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@sonulohani sonulohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do need to add the docs for the feature you've added, in the website as well. Create PR also in https://github.com/cpeditor/cpeditor.github.io

sonulohani
sonulohani previously approved these changes Mar 13, 2021
Copy link
Copy Markdown
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR it makes sense to have "Run on all test cases before submit"

@neko-para neko-para dismissed stale reviews from sonulohani via c774239 March 13, 2021 05:08
coder3101
coder3101 previously approved these changes Mar 13, 2021
@coder3101 coder3101 enabled auto-merge (squash) March 13, 2021 05:13
@coder3101
Copy link
Copy Markdown
Member

#735 priority increased because of this feature. Before submitting all testcases should be ran.

@coder3101 coder3101 merged commit 3ffe83a into master Mar 13, 2021
@coder3101 coder3101 deleted the auto-unchecked-accepted-testcase branch March 13, 2021 05:20
@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

We need to update the docs.

@neko-para
Copy link
Copy Markdown
Contributor Author

The document seems to be updated.
#152

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

The document seems to be updated.
#152

Sorry, I checked the commits and forgot to check the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-uncheck accepted test cases

4 participants