Skip to content

feat: Configurable text cursor width#795

Merged
sonulohani merged 1 commit intocpeditor:masterfrom
sonulohani:feat_add_cursor_width
Mar 13, 2021
Merged

feat: Configurable text cursor width#795
sonulohani merged 1 commit intocpeditor:masterfrom
sonulohani:feat_add_cursor_width

Conversation

@sonulohani
Copy link
Copy Markdown
Contributor

@sonulohani sonulohani commented Mar 12, 2021

Description

Added configurable text cursor width (#781). The text cursor width ranges from 1(default) to 10.

Screenshots (if appropriate)

image

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Copy link
Copy Markdown
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also open a PR in website. It is required.

@sonulohani sonulohani self-assigned this Mar 12, 2021
@neko-para
Copy link
Copy Markdown
Contributor

You can use the following chinese translation
光标宽度
光标的像素宽度

@sonulohani
Copy link
Copy Markdown
Contributor Author

sonulohani commented Mar 13, 2021

Also open a PR in website. It is required.

Added docs in cpeditor/cpeditor.github.io#151

Copy link
Copy Markdown
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the same translation in docs website for Chinese version.

@sonulohani sonulohani merged commit 7561654 into cpeditor:master Mar 13, 2021
@sonulohani sonulohani deleted the feat_add_cursor_width branch March 13, 2021 05:05
@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

How did you update the translations? You have marked the empty Russian translations as finished.

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

BTW, we squash and merge pull requests, so unnecessary force-pushes are confusing.

@ouuan
Copy link
Copy Markdown
Member

ouuan commented Mar 13, 2021

And you should squash and merge instead of creating a merge commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants