Skip to content

fix(Find/Replace): make Find/Replace a dialog instead of a window#767

Merged
ouuan merged 2 commits intomasterfrom
findreplace-is-a-dialog
Feb 12, 2021
Merged

fix(Find/Replace): make Find/Replace a dialog instead of a window#767
ouuan merged 2 commits intomasterfrom
findreplace-is-a-dialog

Conversation

@ouuan
Copy link
Copy Markdown
Member

@ouuan ouuan commented Feb 12, 2021 •
edited
Loading

Description

Make Find/Replace a dialog instead of a window.

Motivation and Context

This makes it a floating window in i3-wm.

How Has This Been Tested?

On Arch Linux i3-wm.

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@ouuan ouuan requested a review from coder3101 February 12, 2021 15:01
@ouuan ouuan merged commit 503ed44 into master Feb 12, 2021
@ouuan ouuan deleted the findreplace-is-a-dialog branch February 12, 2021 15:27
@hitanshu-mehta
Copy link
Copy Markdown
Contributor

hitanshu-mehta commented Nov 27, 2021 •
edited
Loading

Find/Replace dialog is still tiling for me. I also use i3-wm.
Making window non modal fixes it by simply adding this line -> findReplaceDialog->setWindowModality(Qt::NonModal);

@ouuan
Copy link
Copy Markdown
Member Author

ouuan commented Nov 27, 2021

Find/Replace dialog is still tiling for me. I also use i3-wm.

Which version of i3 are you using? Do you have any floating-related i3 configs?

@hitanshu-mehta
Copy link
Copy Markdown
Contributor

hitanshu-mehta commented Nov 27, 2021

i3 version 4.19.1

I have enabled/disabled floating for some classes of windows, but it does not contain anything related to cpeditor.

Here is my floating related configs 
for_window [window_role="pop-up"] floating enable
for_window [window_role="task_dialog"] floating enable

for_window [class="yakuake"] floating enable
for_window [class="systemsettings"] floating enable
for_window [class="plasmashell"] floating enable;
for_window [class="Plasma"] floating enable; border none
for_window [title="plasma-desktop"] floating enable; border none
for_window [title="win7"] floating enable; border none
for_window [class="krunner"] floating enable; border none
for_window [class="Kmix"] floating enable; border none
for_window [class="Klipper"] floating enable; border none
for_window [class="Plasmoidviewer"] floating enable; border none
for_window [class="(?i)*nextcloud*"] floating disable
for_window [class="plasmashell" window_type="notification"] border none, move right 700px, move down 450px
no_focus [class="plasmashell" window_type="notification"]
for_window [title="Desktop — Plasma"] kill; floating enable; border none
for_window [class="Navigator"] floating disable

@ouuan
Copy link
Copy Markdown
Member Author

ouuan commented Nov 27, 2021

Can't reproduce. And we already have findReplaceDialog->setModal(false). I've no idea how findReplaceDialog->setWindowModality(Qt::NonModal) helps 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ouuan @hitanshu-mehta @coder3101