Conversation
coder3101
reviewed
Nov 1, 2020
Member
coder3101
left a comment
coder3101
left a comment
There was a problem hiding this comment.
Overall nice design. I'll refactor some other things to confer to these standards.
4 tasks
Member
|
You can update existing docs PR for these changes. |
ouuan
added
awaiting for docs
Member
|
I'll approve and merge when Russian translation are up to date. Meanwhile you can update the docs PR as well. |
ouuan
removed
the
awaiting for docs
Member
|
@IZOBRETATEL777 please update the translations. |
Member
|
@Sadykhzadeh Please translate this and other PRs. It is ready, just awaiting russian translations. |
coder3101
approved these changes
Nov 10, 2020
ouuan
removed
the
awaiting for translation:RU
4 tasks
ouuan
added a commit
that referenced
this pull request
Jun 27, 2021
* fix: add suffix for Default File Path For Problem URLs This was introduced in #652. * docs: update changelog
ouuan
added a commit
that referenced
this pull request
Jul 22, 2021
* fix: add suffix for Default File Path For Problem URLs This was introduced in #652. * docs: update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better logic and code reuse than #640.
Related Issues / Pull Requests
This closes #640.
Motivation and Context
There are many duplicate codes in #640 and some logics including the
verboseoption are changed. There are also duplicateformat code on savesettings in #640.How Has This Been Tested?
On Arch Linux.
Checklist
oldattribute is updated or it is resolved in SettingsUpdater.tr()orQCoreApplication::translate().Additional text
@IZOBRETATEL777 please update the translations.