feat: use KSyntaxHighlighting and rewrite the code editor with vim mode#516
Closed
feat: use KSyntaxHighlighting and rewrite the code editor with vim mode#516
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update EditorTheme.cpp Update appwindow.hpp Properly set dependency Add Install Scripts for dependency Set +x for scripts before running Fix YAML Error Make windows release type Use ninja build system Add to Windows System Test with Ninja Use default system for ECM and KSH
coder3101
force-pushed
the
ksyntax-highlighting
branch
from
752aef0 to
1c6f7bb
Compare
Member
You should compile before running that script, otherwise auto-generated files are not up-to-date. |
They are not for CI/CD only. They are also helpful for those who want to build CP Editor locally.
Member
|
Are you sure |
Member
Author
|
ouuan
force-pushed
the
ksyntax-highlighting
branch
from
4cb73ee to
8614590
Compare
ouuan
force-pushed
the
ksyntax-highlighting
branch
from
d9e21f0 to
88dc799
Compare
coder3101
changed the title
Member
Author
#581, the original PR for vim mode is closed and it has been ported to this PR, This PR now has fakevim along with ksyntax highlighting. |
…#947) * Change the command-line option --no-hot-exit to --no-restore-session. * Change the command-line option --no-hot-exit to --no-restore-session. * update * style: format codes * style: format codes Co-authored-by: Yufan You <[email protected]> Co-authored-by: ChungZH <[email protected]>
Co-authored-by: coder3101 <[email protected]>
This fixes #1011
4 tasks
Member
Author
|
#1101 is using Kate syntax highlighting. Closing this and new PR for fakevim will be opened. |
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Kate's Syntax highlighter engine for Code Highlighting.
Description
QCodeEditoruses very basic RegEx based matching to highlight code. This has many issues and they are listed in related issues section in the side.ECM and Syntax highlighting builds and links to a shared library.
Related Issue
Fixes #174 and Fixes #210 and Fixes #533 and Fixed #372 and Fixes #393 and Fixes #413
Motivation and Context
To make syntax highlighting more better.
How Has This Been Tested?
Tested on Windows 10
Screenshots (if appropriate)
Type of changes
Checklist
git resetand commit again, or usegit rebase -iandgit commit --amendto modify the commit messages.)tr()orQCoreApplication::translate().Extra Checklist
:(fix Auto indent does not works in python #548).(Optional) Make it possible to choose a custom theme.(Over 20 themes are now available, enough for all)