fix(SignalHandler): properly register signal handlers#1304
Merged
Conversation
assert does not run in release mode This fixes #1168
ouuan
force-pushed
the
fix-signal-assert
branch
from
6123a51 to
2b59810
Compare
coder3101
reviewed
Feb 10, 2024
coder3101
approved these changes
Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stupid error.
assertdoes not run in release mode, so the signal handlers are not registered.Related Issues / Pull Requests
This fixes #1168
How Has This Been Tested?
On Arch Linux with release mode build.
Checklist