Skip to content

fix: MoveToStartOfLine and MoveToEndOfLine behaviors#1149

Closed
ouuan wants to merge 2 commits intomasterfrom
fix-home-end
Closed

fix: MoveToStartOfLine and MoveToEndOfLine behaviors#1149
ouuan wants to merge 2 commits intomasterfrom
fix-home-end

Conversation

@ouuan
Copy link
Copy Markdown
Member

@ouuan ouuan commented Feb 20, 2023

Description

  • MoveToStartOfLine (Home): Move to the first non-whitespace character instead of the start of line if the cursor is after the first non-whitespace character.
  • Fix MoveToStartOfLine and MoveToEndOfLine to make them actually "MoveToStartOfBlock" and "MoveToEndOfBlock", so that they behave as expected when lines are wrapped.

Related Issues / Pull Requests

This fixes #774.

How Has This Been Tested?

On Arch Linux.

Testing on macOS is needed as MoveToStartOfLine is not Home on macOS. And macOS has a MoveToStartOfBlock key sequence, maybe special handling is preferred.

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

@ouuan ouuan marked this pull request as draft February 20, 2023 01:21
@stale
Copy link
Copy Markdown

stale bot commented Mar 23, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issues label Mar 23, 2023
@ouuan ouuan added work in progress The work has been started and is in progress. and removed stale Inactive issues labels Mar 23, 2023
ouuan added a commit that referenced this pull request Feb 13, 2024
@ouuan ouuan closed this Feb 13, 2024
ouuan added a commit that referenced this pull request Feb 13, 2024
…avior (#1310)

* fix(CodeEditor): add ESC to cancel selection

cpeditor/QCodeEditor#35

* fix(CodeEditor): MoveToStartOfLine and MoveToEndOfLine behaviors

Ported from cpeditor/QCodeEditor#41

It fixes #774 and replaces #1149.

* docs: update changelog
@ouuan ouuan deleted the fix-home-end branch February 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress The work has been started and is in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Press QKeySequence::MoveToStartOfLine, go to the first non-blank character

1 participant