fix: MoveToStartOfLine and MoveToEndOfLine behaviors#1149
Closed
fix: MoveToStartOfLine and MoveToEndOfLine behaviors#1149
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ouuan
added a commit
that referenced
this pull request
Feb 13, 2024
Ported from cpeditor/QCodeEditor#41 It fixes #774 and replaces #1149.
1 task
ouuan
added a commit
that referenced
this pull request
Feb 13, 2024
…avior (#1310) * fix(CodeEditor): add ESC to cancel selection cpeditor/QCodeEditor#35 * fix(CodeEditor): MoveToStartOfLine and MoveToEndOfLine behaviors Ported from cpeditor/QCodeEditor#41 It fixes #774 and replaces #1149. * docs: update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MoveToStartOfLine(Home): Move to the first non-whitespace character instead of the start of line if the cursor is after the first non-whitespace character.MoveToStartOfLineandMoveToEndOfLineto make them actually "MoveToStartOfBlock" and "MoveToEndOfBlock", so that they behave as expected when lines are wrapped.Related Issues / Pull Requests
This fixes #774.
How Has This Been Tested?
On Arch Linux.
Testing on macOS is needed as
MoveToStartOfLineis not Home on macOS. And macOS has aMoveToStartOfBlockkey sequence, maybe special handling is preferred.Checklist
oldattribute is updated or it is resolved in SettingsUpdater.tr()orQCoreApplication::translate().