I have tried running release.yml in my repo and got a lot of errors under Windows.

My guess is that window-latest points to Windows Server 2022 and VS 2022, but 2019 is hardcoded in many places in the build process. Ubuntu may also can be updated to 20.04 or 22.04.

My guess is that window-latest points to Windows Server 2022 and VS 2022, but 2019 is hardcoded in many places in the build process.

You may try updating it. It would be preferred if the VS version can be not hardcoded while not adding too much complexity in the scripts.

Ubuntu may also can be updated to 20.04 or 22.04.

linuxdeployqt recommends targeting the oldest still-supported Ubuntu LTS release, which is still 18.04.

There are functions like isPositionInsidexxxx in CodeEditor.cpp which was incomplete in original PR.

The usage would be when highlighting matching parenthesis we will ignore the parenthesis that comes inside comments, single/double quotes or string literals.

Its incomplete here as well.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I'm trying to use KTextEditor.

Currently, basic editing and highlighting work fine. It looks like Kate is studded.

KTextEditor is nice, If we are able to compile on all platforms. Back in the days, it was not fully cross platform. Now it seems a good choice for us.

I recently tried KTextEditor again, referred some code to Kate, and now I can highlight the error line, the text hint is not yet completed, and I guess it will be solved smoothly.

But I'm running into some sticky issues.

• KTextEditor is bound to some shortcut keys, such as Ctrl+S, Ctrl+F, etc., which cause conflicts with the main window.
• KTextEditor has its own Cursor, and it is difficult to convert with QTextCursor, which breaks many functions.
• KTextEditor provides three setting methods, and serialization encountered difficulties.
  1. ConfigInterface, less options.
  2. Editor Config, this component can be embedded in Dialog or Widget. The UI is a bit inconsistent, the language doesn't follow the settings, and Reset doesn't seem to be able to roll back some options.
  3. writeSessionConfig, I haven't tried it, it may be the same as 1 or 2.

To use KTextEditor, we need a massive redesign.

I fixed the bracket matching code. Refer to the code of Kate to maintain the Attribute of each row in the highlighter. Now we can directly get the style at a certain position to judge whether it is in the string or comment. So isPositionInsidexxxx is no longer needed.

https://github.com/rogeryoungh/cpeditor/blob/ksyntax-highlighting2/src/Editor/CodeEditor.cpp#L736-L754

QtFindReplaceDialog waits for cpeditor/QtFindReplaceDialog#9.

I have reviewed the code, and next will test it. Thanks for all your efforts! 😃

Got it here

@ouuan can you test on Linux?
Works fine on macOS and Windows.

It generally works. But see the unchecked items in #516. There are some regressions and unfulfilled enhancements, though not very critical.

Minor regression is fine, we can iron it out slowly in subsequent PR, as for small unfulfilling requirements, we can list it out in a single issue and fix it.

What do you think @rogeryoungh?

I agree with you.

I found a small problem during the test, the color of the error lines and the current line does not mix well, and it cannot be seen under some themes, I will fix it right away.

before

after

We can merge this and let alpha version users find and report bugs or regression.

Hope @rogeryoungh will contribute in fixing and triaging them.

@allcontributors add @rogeryoungh for code