refactor: use Q_SLOTS macro to boost signals compatibility#6
Merged
ouuan merged 1 commit intocpeditor:masterfrom May 15, 2021
Merged
refactor: use Q_SLOTS macro to boost signals compatibility#6ouuan merged 1 commit intocpeditor:masterfrom
ouuan merged 1 commit intocpeditor:masterfrom
Conversation
ouuan
approved these changes
May 15, 2021
ouuan
changed the title
Author
|
Thanks for merging! |
ouuan
added a commit
that referenced
this pull request
Jun 5, 2023
* refactor: use Q_SLOTS macro to boost signals compatibility (#6) * build: update to C++17 (#7) 1. https://invent.kde.org/qt/qt/qtbase/-/commit/6e8ad7201826e75601d902eea741380e37222fc7 requires C++14. 2. Prepare for the Qt 6 migration in the future. * fix: undo a Replace All in a single step (#8) * refactor: small enhancements * fix: undo a Replace All in a single step --------- Co-authored-by: Frank <[email protected]> Co-authored-by: Yufan You <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Q_SLOTS for boost signals compatibility. This will also help when QT_NO_KEYWORDS is defined.