feat(app): file picker full filesystem navigation#495
Merged
Conversation
The file picker's back-navigation (h/backspace/left) was silently broken
because bubbles filepicker defaults to CurrentDirectory "." and
filepath.Dir(".") == ".", making Back a no-op that just reset the cursor.
Fix by resolving CWD to an absolute path via os.Getwd(). Also improve
the picker UX:
- Show live current directory path (dimmed) in the title
- Add navigation hint description (h/← back · enter open)
- Style directories in accent blue bold, files in bright text
- Bold the selected row, use ▸ triangle cursor
- Hide the permissions column (not useful for file uploads)
closes #485
Verify that h/backspace/left navigate to the parent directory and that the title updates to reflect the current path. The back-navigation test fails without the CurrentDirectory(absolutePath) fix — confirming the regression is caught. closes #485
The tesseract chocolatey package intermittently fails to download due to CDN issues. Wrap the choco install in a PowerShell retry loop (3 attempts with 10s backoff). Also set fail-fast: false so a single matrix failure doesn't cancel the other OS jobs. Add explicit shell: pwsh so actionlint/shellcheck doesn't try to parse the PowerShell syntax as bash. closes #485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filepath.Dir(".")returned".", so pressing h/backspace/left was a no-op that just reset the cursor to the top. Resolved by using an absolute CWD path.h/← back · enter open)Reproduction (before fix)
h,backspace, orleftto navigate upg)Test plan
TestFilePickerBackNavigatesUp— all three back keys navigate to parent; fails without the fixTestFilePickerTitleShowsCurrentDir— title updates to reflect current directory after navigatingFile to attach in ~/...with dimmed pathl/right/enter— title path updatesh/backspace/left— navigates to parent, title path updates/and back down▸triangle cursor on selected rowh/← back · enter openstays fixed width below titlecloses #485
🤖 Generated with Claude Code