Conversation
22adc06 to
0847b05
Compare
Wire up the existing DocumentEntityServiceLog polymorphic link in the UI so users can attach and browse documents (receipts, invoices, etc.) on individual service log entries. - Add "Docs" drilldown column to service log table with document counts - Add serviceLogDocumentDef detail definition and routing - Handle serviceLogColDocs in the exhaustive inline-edit switch - Add tests for doc count rendering, handler form kind, drilldown routing closes #427 Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Make serviceLogColDocs fall through to startEditServiceLogForm, matching the pattern used by all other entity Docs columns - Harden formKind route matching: treat nil handler as "no match" instead of matching all formKind-scoped routes - Extract entityIDs generic helper to replace 10 instances of manual ID-collection boilerplate in handlers - Add doc count cell tests for maintenance, quote, and vendor rows (previously only service log had coverage) - Rename TestMaintenanceColumnsIncludeLog to TestMaintenanceColumnsIncludeLogAndDocs Co-Authored-By: Claude Opus 4.6 <[email protected]>
0847b05 to
54a7064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceLogDocumentDef,maintenanceDocumentDef,quoteDocumentDef, andvendorDocumentDefdetail definitions with routingformKinddiscriminator ondetailRouteso nested detail views (e.g. appliance -> maintenance -> docs) route to the correct document def instead of the parent tab's; nil handler is treated as "no match" to prevent fallback surprisesentityIDsgeneric helper to replace repeated manual ID-collection boilerplate in handlersSteps to reproduce
closes #427