Accept pathlib.Path as arguments#34
Merged
cpburnz merged 9 commits intocpburnz:masterfrom Mar 2, 2020
pykong:path_args
Merged
Conversation
cpburnz
requested changes
Feb 27, 2020
Owner
cpburnz
left a comment
cpburnz
left a comment
There was a problem hiding this comment.
Except for a few minor critiques this looks excellent. Thank you.
Contributor
Author
|
@cpburnz Thanks for having a look. |
Owner
|
Looks good, thanks. |
Contributor
Author
|
You are welcome. |
Closed
bors Bot
added a commit
to rehandalal/therapist
that referenced
this pull request
Apr 20, 2020
118: Update pathspec to 0.8.0 r=rehandalal a=pyup-bot This PR updates [pathspec](https://pypi.org/project/pathspec) from **0.7.0** to **0.8.0**. <details> <summary>Changelog</summary> ### 0.8.0 ``` ------------------ - `Issue 30`_: Expose what patterns matched paths. Added `util.detailed_match_files()`. - `Issue 31`_: `match_tree()` doesn't return symlinks. - `Issue 34`_: Support `pathlib.Path`\ s. - Add `PathSpec.match_tree_entries` and `util.iter_tree_entries()` to support directories and symlinks. - API change: `match_tree()` has been renamed to `match_tree_files()`. The old name `match_tree()` is still available as an alias. - API change: `match_tree_files()` now returns symlinks. This is a bug fix but it will change the returned results. .. _`Issue 30`: cpburnz/python-pathspec#30 .. _`Issue 31`: cpburnz/python-pathspec#31 .. _`Issue 34`: cpburnz/python-pathspec#34 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pathspec - Changelog: https://pyup.io/changelogs/pathspec/ - Repo: https://github.com/cpburnz/python-path-specification </details> Co-authored-by: pyup-bot <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes
pathspecto work with pathlib.Path objects.normalize_fileandnormalize_filesCloses: #33