Trailing slash should catch directories #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found an issue where if you provide a .gitignore line with a trailing slash ('foo/'), it will match files inside but not the directory itself. The .gitignore spec specifies that the directory should be matched as well. This commit changes the end of spec regex to * to fix this issue.
cpburnz
added a commit
that referenced
this pull request
Jul 30, 2014
Trailing slash should catch directories
dahlia
added a commit
to spoqa/python-path-specification
that referenced
this pull request
Sep 14, 2014
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where if you provide a .gitignore line with a trailing slash ('foo/'), it will match files inside but not the directory itself. The .gitignore spec specifies that the directory should be matched as well. This commit changes the end of spec regex to * to fix this issue.