Add equality method to PathSpec #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvie
reviewed
Mar 27, 2017
pathspec/pathspec.py
Outdated
| Tests equality of this ``PathSpec`` with ``other`` based on the | ||
| regexs contained in their ``patterns``. | ||
| """ | ||
| paired_patterns = zip(self.patterns, other.patterns) |
There was a problem hiding this comment.
You might need to use zip_longest() here to avoid equality when one is a "prefix" of the other.
This catches the case where one PathSpac's patterns are a subset of another which would cause a false positive when comparing them.
Owner
|
Thanks, I'll look over this tonight. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
__eq__method so you can compare two PathSpec instances for equality.Personally I want this to see if a PathSpec instance has been instantiated with a default gitignore but I'm sure it would be useful to others too :)