Skip to content

Commit 949bc63

Browse files
fix(docs): let update_versions.sh report a failed Talos fetch
Address review feedback from gemini-code-assist on hack/update_versions.sh:57: under `set -e`/`set -o pipefail` a failed curl pipeline made the command substitution exit the script before the validation block, so the helpful "could not read a Talos version" error never printed. Append `|| true` so the fetch failure falls through to the validation block instead. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent ed8f6be commit 949bc63

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎hack/update_versions.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ fi
5454
# -------------------- 1. Talos version from the installer profile --------------------
5555
INSTALLER_PATH="packages/core/talos/images/talos/profiles/installer.yaml"
5656
INSTALLER_URL="https://raw.githubusercontent.com/${SOURCE_REPO}/${BRANCH}/${INSTALLER_PATH}"
57-
talos="$(curl -fsSL "$INSTALLER_URL" 2>/dev/null | awk '/^version:[[:space:]]/{print $2; exit}')"
57+
talos="$(curl -fsSL "$INSTALLER_URL" 2>/dev/null | awk '/^version:[[:space:]]/{print $2; exit}' || true)"
5858
if [[ ! "$talos" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
5959
echo "Error: could not read a Talos version from $INSTALLER_URL (got '${talos:-}')." >&2
6060
exit 1

0 commit comments

Comments
 (0)