Skip to content

Commit 1c3cb2b

Browse files
fix(docs): let update_versions.sh report a failed release-tag lookup
Address review feedback from gemini-code-assist on hack/update_versions.sh:70: same `set -e`/`pipefail` premature-exit issue on the `git ls-remote` pipeline. Append `|| true` so a failed lookup falls through to the validation block. The `sort -V` portability suggestion is intentionally not taken: the repo standardises on GNU `sort -V` (hack/download_openapi.sh, hack/init_version.sh), so this stays consistent with the existing scripts. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 949bc63 commit 1c3cb2b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎hack/update_versions.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ if [[ -z "$COZYSTACK_TAG" ]]; then
6767
# api/apps/v1alpha1/* submodule tags and any -rc/-beta pre-releases).
6868
COZYSTACK_TAG="$(git ls-remote --tags --refs "https://github.com/${SOURCE_REPO}.git" 'v*.*.*' \
6969
| awk -F/ '/refs\/tags\/v[0-9]+\.[0-9]+\.[0-9]+$/{print $NF}' \
70-
| grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -1)"
70+
| grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -1 || true)"
7171
fi
7272
if [[ ! "$COZYSTACK_TAG" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
7373
echo "Error: could not determine a cozystack release tag (got '${COZYSTACK_TAG:-}')." >&2

0 commit comments

Comments
 (0)