Repository navigation
If system_disk unspecified then disk is not substituted #4
Description
If system_disk unspecified:
talosctl -e 192.168.88.50 -n 192.168.88.50 disks --insecure
DEV MODEL SERIAL TYPE UUID WWID MODALIAS NAME SIZE BUS_PATH SUBSYSTEM READ_ONLY SYSTEM_DISK
/dev/sda VMware Virtual S - HDD - - scsi:t-0x00 - 32 GB /pci0000:00/0000:00:10.0/host2/target2:0:0/2:0:0:0/ /sys/class/block
this line rendered with empty string:
this generates errors like:
./talm apply -f nodes/srv1.yaml -i
- talm: file=nodes/srv1.yaml, nodes=[192.168.88.50], endpoints=[192.168.88.50]
error applying new configuration: rpc error: code = InvalidArgument desc = configuration validation failed: 2 errors occurred:
* an install disk is required in "metal" mode
* specified install disk does not exist: ""
we have to update talm.discovered.system_disk_name to provide first discovered disk by default in case if system_disk is not found:
Activity
Fix: always specify disk, even if system_disk not found
fix(docs+commands): branch-review pass 1 — README accuracy + Phase 2C UX
docs(readme): align apply-safety-gates bullets with #189/#190/#192 ch…
feat(apply,upgrade): apply-safety follow-ups (#189 + #190 + #191 + #192)
feat(apply,upgrade): apply-safety follow-ups (#189 + #190 + #191 + #192)
feat(apply,upgrade): apply-safety follow-ups (#189 + #190 + #191 + #192)