Skip to content

talm apply: maintenance-connection warning lacks per-node prefix on multi-node insecure #191

Closed

Description

Multi-node talm apply output prefixes the drift / divergence headers with the node identifier (talm: drift preview (node 192.0.2.10)), but the maintenanceConnectionMessage line that fires on the insecure path is bare:

talm: drift verification unavailable on maintenance connection
talm: drift verification unavailable on maintenance connection

On a multi-node insecure apply (rare — usually only during bootstrap or recovery) the operator sees the same line twice with no way to tell which node it came from. Inconsistent with the per-node-prefixed drift / divergence headers.

Scope: thread nodeID through the existing previewDrift / verifyAppliedState callsites and use the existing nodePrefix helper. One-liner per caller. A pinning test could mirror TestPreviewDrift_MultiNode_HeaderCarriesNodeID with the insecure path branch.

Activity

  1. added
    kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debt
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    triage/acceptedIndicates an issue is ready to be actively worked on
    area/applyIssues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)
    on May 12, 2026
  2. added a commit that references this issue on May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/applyIssues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)good first issueGood for newcomerskind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions