Skip to content

chart: drop redundant int() wrapper around cidrPrefixLen calls #166

Closed

Description

cidrPrefixLen (engine helper in pkg/engine/helm/engine.go) returns Go int. Two chart-side callers wrap it in Sprig's int:

The third caller in the same file (link_name_for_address line 429) uses the bare form $prefixLen := cidrPrefixLen $address directly. The outer int is a no-op; dropping it brings the three call sites into one consistent style.

Reference: PR #163 review, flagged as non-blocking.

Activity

  1. added
    kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debt
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)
    on May 11, 2026
  2. lexfrei commented on May 14, 2026

    @lexfrei
    ContributorAuthor

    Resolved by #208 (merged into main as 6e914ea).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longterm

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions