You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3f34474
Browse filesBrowse the repository at this point in the historyBrowse files
fix: normalize template paths for Windows compatibility (#88)
* fix: normalize template paths for Windows compatibility
Use filepath.ToSlash to convert OS-specific path separators to forward
slash for consistency with helm engine and embed.FS which always use
forward slash internally. This fixes issue #10 where
Windows users get "template not found" errors when using backslash
in template paths.
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
* fix(tests): remove broken lookup tests from helm engine
Remove TestRenderWithClientProvider and TestRenderWithClientProvider_error
tests that reference non-existent ClientProvider interface and
RenderWithClientProvider function. These tests were inherited from
upstream Helm but never adapted for talm's LookupFunc implementation.
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
* refactor: address QA review findings
- Export NormalizeTemplatePath and use in template.go
- Add comment explaining path.Join vs filepath.Join choice
- Update function documentation
- Add edge case tests
- Remove unused generateModeline function
- Fix linter issues (error wrapping, unhandled error)
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
* fix(template): normalize paths in error fallbacks
When filepath.Abs() fails for either RootDir or individual template
paths, the fallback code now properly normalizes paths using
engine.NormalizeTemplatePath() instead of passing raw OS-specific
paths to the helm engine.
This fixes Windows path handling in edge cases where Abs() fails.
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
* fix(template): fix modeline path handling
Fix two bugs in the modeline path resolution loop:
1. Normalize paths in error fallback when filepath.Abs(RootDir) fails
2. Use correct variable absRootDirModeline instead of absRootDir
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
* style: fix gofmt formatting
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
---------
Signed-off-by: Aleksei Sviridkin <[email protected]>
Co-authored-by: Claude <[email protected]>
0 commit comments